Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vscode new version 1.81 hide popup immediately GitLens commit details #2906

Open
quyenvsp opened this issue Sep 6, 2023 · 7 comments · May be fixed by #2927
Open

Vscode new version 1.81 hide popup immediately GitLens commit details #2906

quyenvsp opened this issue Sep 6, 2023 · 7 comments · May be fixed by #2927
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature blocked Blocked or caused by an upstream issue or feature bug Something isn't working

Comments

@quyenvsp
Copy link

quyenvsp commented Sep 6, 2023

Description

Does this issue occur when use old version 1.80.2?: No

  • VS Code Version: 1.81.1
  • OS Version: Windows 11

Steps to Reproduce:

  1. Install plugin GitLens
  2. Hover Commit message for show suggest
  3. Click Commit ID for show Quick commit details

Expert:
Quick commit details popup should show and keep present.

Actually:
Popup show but hide immediately

Log:

When occur:

TRACE CommandService#executeCommand gitlens.showQuickCommitDetails
(22) log.ts:401 TRACE CommandService#executeCommand _setContext

When work normally:

TRACE CommandService#executeCommand gitlens.showQuickCommitDetails
(11) log.ts:401 TRACE CommandService#executeCommand _setContext
vscode_gitlens_bug.mp4

GitLens Version

14.2.1

VS Code Version

Version: 1.81.1 (system setup)
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:22:42.175Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.22621

Git Version

git version 2.42.0.windows.2

Logs, Screenshots, Screen Captures, etc

No response
@quyenvsp quyenvsp added bug Something isn't working triage Needs to be looked at labels Sep 6, 2023
@eamodio
Copy link
Member

eamodio commented Sep 13, 2023

Can you still reproduce this in 1.82?

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Sep 13, 2023
@quyenvsp
Copy link
Author

@eamodio yes it still here.

Version: 1.82.1 (system setup)
Commit: 6509174151d557a81c9d0b5f8a5a1e9274db5585
Date: 2023-09-08T08:45:05.575Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22621

Gitlens plugin version: 14.3.0

I am using hyper v virtual machine for reproduce. Just only Gitlens installed with default clean Vscode.

Here are more log, you can see CommandService#executeCommand _setContext, when it work only (11). when not work it show (22) times

image

@eamodio eamodio added blocked: vscode Caused by or dependent on a VS Code issue or feature blocked Blocked or caused by an upstream issue or feature and removed needs-more-info Needs further information, steps, details, etc. labels Sep 14, 2023
@eamodio
Copy link
Member

eamodio commented Sep 14, 2023

VS Code controls the focus behavior that is likely causing this. Please open an issue on the VS Code repository. Thanks!

@quyenvsp
Copy link
Author

quyenvsp commented Sep 14, 2023 via email

@quyenvsp quyenvsp linked a pull request Sep 20, 2023 that will close this issue
Open
7 tasks
quyenvsp added a commit to noncheat/vscode-gitlens that referenced this issue Sep 20, 2023
@quyenvsp
Closes gitkraken#2906 correct focus before show quick commit popup
6d6389f
@eamodio
Copy link
Member

eamodio commented Nov 27, 2023

I posted this one the PR:

Sorry for the delay. I can't reproduce this issue but it must be a VS Code bug of some kind. Since this "fix" is a hack to workaround that bug and that it is forcing focus to something that may or may not have focus, I don't think GitLens should attempt to fix it. Forcing focus to the active editor group, could have implications to keyboard usage and screen reader support.

Since you already opened an issue on the VS Code repo, can you provide a link to it and I can comment on it. Although without a strong reproduction it might be hard. I would also suggest checking the VS Code settings you have set to see if there is maybe a combination of them that is causing the behavior (e.g. editor.hover.*)

@quyenvsp
Copy link
Author

Thank you, from begin I have installed on Hyper-V virtual and only Gitlens plugin installed for sure all is Default setting.
Today, it still happen with all latest Windows 11, Vscode, Gitlens plugin.
But no problem, because you can't reproduce and I fixed by install customize Gitlens build myself. So all seem fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature blocked Blocked or caused by an upstream issue or feature bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix focus before show quick commit popup noncheat/vscode-gitlens
3 participants
@eamodio @quyenvsp and others