Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentSectionContent Error after the video element update #321

Open
NeilCoyne opened this issue Aug 25, 2023 · 5 comments
Open

ComponentSectionContent Error after the video element update #321

NeilCoyne opened this issue Aug 25, 2023 · 5 comments

Comments

@NeilCoyne
Copy link

Uncaught SyntaxError: Identifier 'ComponentSectionContent' has already been declared (at section.js:1:1)

@givanz
Copy link
Owner

givanz commented Aug 25, 2023

Hi

I'm unable to reproduce this bug, can you provide more details or steps to reproduce?

It happens on demo https://www.vvveb.com/vvvebjs/editor.html also?

The component is Embed video (youtube, vimeo) or Video (native html video)?

What properties I should change for the error to show?

Can you try to disable all browsers extensions and retry? some browsers extensions sometimes interfere with page content.

@NeilCoyne
Copy link
Author

Hello, Sure I just check again so I downloaded a fresh clean zip of the code added it to a local env (ampps) on local server navigated to editor.html or editor.php
and I get the error ..
using Chrome, FF, and edge all give same error.. tried with all extensions disabled in incognito mode same error

I am only presuming it is related to the video update to the code you added two weeks again , as this is when I saw the error.
(no it is not happening on https://www.vvveb.com/vvvebjs/editor.html )

@givanz
Copy link
Owner

givanz commented Aug 25, 2023

Thanks for details.

This was caused by Section component that was moved from https://github.com/givanz/VvvebJs/blob/master/libs/builder/components-elements.js into a separate file https://github.com/givanz/VvvebJs/blob/master/libs/builder/section.js and ComponentSectionContent was not deleted from components-elements.js.

It's fixed in the last commit d9e8e3a

@NeilCoyne
Copy link
Author

Excellent thanks so much .. such great code by the way I am loving playing arround with it ;-)

@givanz
Copy link
Owner

givanz commented Aug 25, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants