Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use system colors for the shell #6

Open
flying-sheep opened this issue Apr 4, 2015 · 6 comments
Open

use system colors for the shell #6

flying-sheep opened this issue Apr 4, 2015 · 6 comments

Comments

@flying-sheep
Copy link

UI should use system colors to integrate

@jdm
Copy link
Collaborator

jdm commented Apr 4, 2015

@flying-sheep Want to file a corresponding issue in rust-cssparser to figure out how to support nonstandard properties like this? The idea of adding platform-specific code to https://github.com/servo/rust-cssparser/blob/master/src/color.rs#L99 to figure these values out isn't particularly appealing :)

@flying-sheep
Copy link
Author

nonstandard? where did you get that idea from?

will do. and yeah, that doesn’t sound too clean given that it needs to be resolved at runtime (OS color themes can change at any time and differ between applications)

but there already is the special value Color::CurrentColor, so we’d just need to add 28 more special values.

and yeah, as said in the standard, we could use apperance instead, but i guess that’s more work… just think about what apparance: tab would imply instead of a simple color: WindowText; background: Window; border: 1px solid WindowFrame. besides, the current version of CSS3-UI has no mention of apperance, so the deprecation notice is pretty unhinged (deprecated in favor of something that was decided against?)

@flying-sheep
Copy link
Author

fyi: the issue exists, and is the only currently open one: servo/rust-cssparser#2

@jdm
Copy link
Collaborator

jdm commented Apr 4, 2015

@flying-sheep
Copy link
Author

yeah, but as i said there: appearance has only the “button” value, so it’s useless, and system colors are the closest to get a semblance of native appearance.

@flying-sheep
Copy link
Author

flying-sheep commented Aug 2, 2023

That issue has been closed, system colors are back in the standard (not all of them, many individual ones have been deprecated):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants