Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify predict to allow fixed b, varying parameters #953

Open
bbolker opened this issue Oct 8, 2023 · 2 comments
Open

modify predict to allow fixed b, varying parameters #953

bbolker opened this issue Oct 8, 2023 · 2 comments

Comments

@bbolker
Copy link
Contributor

bbolker commented Oct 8, 2023

based on this code

  • we can probably allow fast=TRUE to handle the newparams argument
  • we should fix b (by default?) by setting map when modifying parameters
@bbolker
Copy link
Contributor Author

bbolker commented Oct 10, 2023

question for others (@mebrooks, @kaskr); does it make sense to always map b, or should we have a switch that enables this? (i.e., what are the reasonable use cases for someone wanting to (1) modify beta parameters and re-estimate b correspondingly vs. (2) modify beta parameters and leave b fixed at their MLE values? (option 2 seems more sensible to me but I don't know if I can rule out option 1)

@bbolker
Copy link
Contributor Author

bbolker commented Apr 26, 2024

As suggested in recent issues around the marginaleffects package, we almost certainly do want to fix b when beta values are being modified (because e.g. things like log-likelihood profiling will break if we don't). The extend_re_form branch is relevant here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant