Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CLDR to v37 and remove adopted cldr-data* packages #4874

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 23, 2023

Fixes #4403. Related to #3998.

Changelog Entry

Fixed

  • Fixes #4403. Bump to CLDR v37 and remove adopted cldr-data and cldr-data-downloader packages, by @compulim, in PR #4874

Description

We are bumping CLDR to v37 from the official Unicode repository, despite the current is v43.

We adopted cldr-data and cldr-data-downloader to fix their vulnerabilities and patching plurals for Polish and Portuguese language (bug of CLDR v36). However, we no longer need both packages as we download from the official Unicode repository.

Design

globalize does not support CLDR v38 or up due to new "c" parameter added to French plurals and globalize did not update its dependency on make-plural package. Thus, we cannot bump to v38 or beyond until globalize resolved the issue.

Specific Changes

  • Imports CLDR from cldr-core and other packages
  • Removes cldr-data and cldr-data-downloader
  • Moved Polish and Portuguese plurals patch to createPrecompileGlobalize script
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed~
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review September 23, 2023 06:20
@compulim compulim added this to the imminent milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploaded file in Polish appears to be empty Unit Formatter Returning Internal Error with CLDR v40.0.0
1 participant