#85 Added a DialContext method to all sockets. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2020 10:33
Made Dial use the sockets default timeout (uses DialContext now). Addjusted some tests to use DialContext.
sbinet
reviewed
Nov 6, 2020
| @@ -32,6 +35,9 @@ type Socket interface { | |||
| // Dial connects a remote endpoint to the Socket. | |||
| Dial(ep string) error | |||
|
|
|||
| // Dial connects a remote endpoint to the Socket. | |||
| DialContext(ctx context.Context, ep string) error | |||
There was a problem hiding this comment.
the doc string of the Dial method should be updated to reflect the implied semantics.
the csocket implementation (for integration w/ cgo-zmq4) should be updated as well.
alternatively, we could just merge the 2 methods together, documenting that the context.Context would be wrapped with the socket's configured timeout.
I think I'd err on the latter.
the csocket implementation would still need to be updated, though :)
| ) | ||
|
|
||
| var ( | ||
| errInvalidAddress = errors.New("zmq4: invalid address") | ||
|
|
||
| ErrBadProperty = errors.New("zmq4: bad property") | ||
| ErrBadProperty = errors.New("zmq4: bad property") | ||
| ErrUnknownTransport = errors.New("zmq4: unknown transport") |
There was a problem hiding this comment.
instead of a value, I'd rather have it as a type, TransportError or something, so we could provide the name of the unknown transport.
There was a problem hiding this comment.
Make it a feature request.
Not related to this PR at all.
|
ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85 Made Dial use the sockets default timeout (uses DialContext now).
Addjusted some tests to use DialContext.
Added TestNullHandshakeRRFail.
Added DialContext method to Socket interface and all sockets.
The timeout is now based on the context, simplified the waiting.