shortcode output wrapped in p-tags

[bep]

See

http://discuss.gohugo.io/t/info-img-shortcode-figure-tag-auto-wrapped-in-p-tag-invalid-html/1202/5

[bep]

I remember adding divs around the shorcode placeholders to prevent this, but this was modified by @halostatue to fix an issue with the relref shortcodes. I guess we can remove the superflous p tags when doing the replacement.

[halostatue]

👍

[bep]

Yea, well, a expansion of the regexp in the last replace func is a 15% slow-down on my not very shortcode-heavy site.

For the shortcodereplacement alone:

BenchmarkReplaceShortcodeTokens     916019        1714125       +87.13%

Back to the thinking box.

[darylteo]

I'm trying to understand the source (not a go dev sorry), and it looks like you're processing the shortcodes and replacing them with shortcode placeholders. Perhaps if you replaced it with a html based placeholder markdown wouldn't wrap it with paragraphs tags.

For example:

func createShortcodePlaceholder(id int) string {
    return fmt.Sprintf("<div %s=\"%d\"></div>", shortcodePlaceholderPrefix, id)
}

Anyway, fixing this would be really handy, although it isn't a "end of the world" issue I suppose. I'm working around this by putting div tags around the shortcode on the content itself.

[bep]

@darylteo you are correct, that was my initial approach. But @halostatue changed that as it had some other side effects.

[bep]

@darylteo I have tested this one pretty good myself, but it would be cool if you also could take the latest source for a spin and confirm that it it's fixed for you.

[nicolinuxfr]

Is it related in any way with <p> around images or not at all ?

[bep]

@nicolinuxfr it is if you use the figure shortcode and similar.

[nicolinuxfr]

@bep nope, I'm using plain Markdown to insert images and I have <p>around them. I guess I should open a new bug report then ?

[bep]

@nicolinuxfr yes, but that would be for Blackfriday: https://github.com/russross/blackfriday/issues

[darylteo]

@nicolinuxfr Images would be inline so they should have p's around them, I
believe.

@bep I will try. I'm installing Hugo via Brew so I'll need to figure out
how to get a custom build first =)

On Tue, Jun 23, 2015 at 5:35 AM, Bjørn Erik Pedersen <
notifications@github.com> wrote:

@nicolinuxfr https://github.com/nicolinuxfr yes, but that would be for
Blackfriday: https://github.com/russross/blackfriday/issues

—
Reply to this email directly or view it on GitHub
#1148 (comment).

[dunn]

@darylteo if you just need the latest commits from the master branch, brew install --HEAD hugo

[darylteo]

@dunn wonderful

@bep confirmed working for my use cases (figure and youtube shortcodes)

[jeanlucmongrain]

Well, this isn't totally fixed.

If I use the follow shortcode shortcodes/bleh.html:

<div>
    {{ .Inner }}
</div>

that way:

{{% bleh %}}
Markdown content
{{% /bleh %}}

it render like this:

<div>
Markdown content
<p></div></p>

[bep]

@bclermont to mee that looks like another issue, but I may be wrong. Looks like a Blackfriday issue, but if that is your complete shortcode, your work around would be to replace % with < and >, because content inside div is ignored by Blackfriday, anyway (or, it should be according to spec).

But could you create another issue for your case?

[jeanlucmongrain]

@bep I think you're right, I will investigate a little more.

is that normal that when I switch {{% to {{< inner markdown don't render anymore?

[bep]

@bclermont yes, the < syntax was added in 0.14 to handle use cases with raw HTML that didn't need Markdown rendering (or, the Markdown rendering messed it up badly ...)

[jeanlucmongrain]

I created a separated issue #1387 for that with a project to reproduce the problem

[josharcheruk]

The original bug appears to still be active in certain situations as described here:

https://discuss.gohugo.io/t/shortcodes-and-p-tags/2164/5

Should this issue be reopened or a separate one created?

[bep]

Separate.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.