helpers: fix invalid pagination links #2374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shapeshed
changed the title
The path helper incorrectly transforms valid urls causing issues with pagination. One example is `.net` http://localhost:1313/tags/.net/ to http://localhost:1313/tags/index.net/page/2 The commit adds a regex test to check for `.xml` or `.html` extensions and applies the transformation on a match. This allows valid URLs like /foo/index.html/bar to also be passed through. Fixes gohugoio#2110
shapeshed
changed the title
bep
added a commit
to bep/hugo
that referenced
this pull request
Mar 27, 2017
This is a pretty fundamental change in Hugo, but absolutely needed if we should have any hope of getting "multiple outputs" done. This commit's goal is to say: * Every file target path is created by `createTargetPath`, i.e. one function for all. * That function takes every page and site parameter into account, to avoid fragile string parsing to uglify etc. later on. * The path creation logic has full test coverage. * All permalinks, paginator URLs etc. are then built on top of that same logic. Fixes gohugoio#1252 Fixes gohugoio#2110 Closes gohugoio#2374 Fixes gohugoio#1885 Fixes gohugoio#3102 Fixes gohugoio#3179 Fixes gohugoio#1641 Fixes gohugoio#1989
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path helper incorrectly transforms valid urls causing issues with
pagination. One example is
.nethttp://localhost:1313/tags/.net/
to
http://localhost:1313/tags/index.net/page/2
The commit adds a regex test to check for
.xmlor.htmlextensionsand applies the transformation on a match.
This allows valid URLs like /foo/index.html/bar to also be passed
through.
Fixes #2110