Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not FirstUpper Taxonomy titles #5172

Closed
Schnouki opened this issue Sep 6, 2018 · 7 comments · Fixed by #5173
Closed

Do not FirstUpper Taxonomy titles #5172

Schnouki opened this issue Sep 6, 2018 · 7 comments · Fixed by #5173

Comments

@Schnouki
Copy link
Contributor

Schnouki commented Sep 6, 2018

Hi,

I'm trying to use tags that are fully lowercase. But even with preserveTaxonomyNames, they are "victims" of helper.FirstUpper() in

p.title = helpers.FirstUpper(key)
.

I'm aware of #1880 and #3070, but this is still annoying for me. Would it be possible to add another option to prevent helper.FirstUpper() from being called? preserveTaxonomyCase maybe?

@bep
Copy link
Member

bep commented Sep 6, 2018

Would it be possible to add another option to prevent helper.FirstUpper() from being called? preserveTaxonomyCase maybe?

No, there are already too many options. So any fix to this must be "optionless".

@Schnouki
Copy link
Contributor Author

Schnouki commented Sep 6, 2018

Can't disagree with that. I'll try to find a way to solve this without breaking anything for people who rely on the current behavior.

@bep
Copy link
Member

bep commented Sep 6, 2018

@Schnouki I think the FirstUpper was a mistake (my mistake). I think we should just remove that and mention it in bold letters in the release notes.

Thoughts @kaushalmodi @regisphilibert and gang?

@kaushalmodi
Copy link
Contributor

kaushalmodi commented Sep 6, 2018

@Schnouki By taxonomy labels, you mean titles? If so, I agree that Hugo should not force FirstUpper.

A user can do so if they wish in their layouts... (or am I missing something?).

I think I'll be fine with this FirstUpper removed.

@onedrawingperday
Copy link
Contributor

A user can do so if they wish in their layouts...

They can.

I agree that this should be removed.

@kaushalmodi
Copy link
Contributor

Also, turns out that I haven't set preserveTaxonomyNames, so I'm already enjoying the taxonony titles not getting forced to FirstUpper :). So yeah, removing that makes sense.

@bep bep added the Enhancement label Sep 6, 2018
@bep bep added this to the v0.49 milestone Sep 6, 2018
@bep bep changed the title Taxonomy labels can't be fully lowercase Do not FirstUpper Taxonomy titles Sep 6, 2018
Schnouki added a commit to Schnouki/hugo that referenced this issue Sep 6, 2018
Doing so was probably a mistake. This may be a breaking change for some people,
but it's easy to restore the previous behaviour in the layouts.

Fixes gohugoio#5172
@bep bep closed this as completed in #5173 Sep 6, 2018
bep pushed a commit that referenced this issue Sep 6, 2018
Doing so was probably a mistake. This may be a breaking change for some people,
but it's easy to restore the previous behaviour in the layouts.

Fixes #5172
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants