Fix connection.verify_mode for Net::HTTP https connection to VERIFY_PEER

[kaiwren]

Also, make it configurable. See http://www.rubyinside.com/how-to-cure-nethttps-risky-default-https-behavior-4010.html

[nikhilvallishayee]

I have defaulted the verify_mode to VERIFY_PEER while creating a connection and made it configurable by being able to pass an options hash to the create method specifying the verify_mode

[kaiwren]

Remember to update the changelog once this is complete.

[jasim]

1. All HTTPS requests are VERIFY_PEER. The option to choose VERIFY_NONE is not exposed to the Uri object.

2. VERIFY_MODE value is being expected as a string:
   if options[:verify_mode] == 'VERIFY_NONE'

   It should ideally be the symbol OpenSSL::SSL::VERIFY_PEER itself.

[nikhilvallishayee]

Fixed and pushed a week back. Hasn't been updated here for unknown reason. Redid push. Still not updated!

[kaiwren]

What's happening on this one? Nik, could you link to the commits that you're talking about? Also, did you see my comments on the use of constants on 92a6acf ?

[nikhilvallishayee]

done!
kaiwren@c74c020

[kaiwren]

Nik, could you also take a look at #66? It seems to be a consequence of switching to always verifying certificates.