-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/review/git-codereview: set git config commit.gpgsign to false #67402
Comments
Thanks for reporting this. The git configuration surface is quite large, and this appears to be a case where one of the configuration values conflicts with the expectations of git-codereview, causing test errors. Can you clarify if this is causing a problem for your workflow? Or are you simply reporting it because you spotted it? While git-codereview can be updated for this particular case, it might not be viable to do that holistically. An alternative approach is to not to use this configuration when working with Go repositories. For example, that can be done by running |
Thanks for your comment. I reported this simply I spotted it. I tried again with setting
Verify the configs:
Test still fails, for example:
The commit used for test is:
However with the following diff (in my local git branch):
Now the test passes:
|
I think this is just about the unit test in git-codereview which creates new repositories? |
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
Go version
go version go1.22.2 linux/amd64
Output of
go env
in your module/workspace:What did you do?
git config --global commit.gpgsign true
git clone https://go.googlesource.com/review
cd review
go test -v
What did you see happen?
Errors like below occurred:
What did you expect to see?
All test passes.
The text was updated successfully, but these errors were encountered: