-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/rsa: check RSA private/public key size before using it #66918
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: d6c9c67) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
This PR (HEAD: 78a81ad) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
This PR (HEAD: 4819097) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
Message from Xin Zhang: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Xin Zhang: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 10: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-02T05:39:55Z","revision":"f16f2aaf8abeb0da9a92852f39df41f269d6079b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 10: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):
Build or test failure, click here for results. Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
This PR (HEAD: 99f4198) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
This PR (HEAD: 1f846d6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
Message from Xin Zhang: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
This PR (HEAD: 57bbcb4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
Message from qiu laidongfeng2: Patch Set 13: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Xin Zhang: Patch Set 14: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
This PR (HEAD: 55424ac) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
Message from Xin Zhang: Patch Set 14: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 15: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 15: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-05T09:36:14Z","revision":"07071369473abcd74f8f4ed02108ee2bfe772c94"} Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 15: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 15: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):
Build or test failure, click here for results. Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 15: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
This PR (HEAD: c801e2c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
Message from Xin Zhang: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 16: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 16: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-06T11:50:50Z","revision":"df90e652b2b799e6276deba763789978762a9624"} Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 16: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 16: This CL has failed the run. Reason: Failed Tryjobs:
Build or test failure, click here for results. Additional links for debugging:
Build or test failure, click here for results. Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 16: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
This PR (HEAD: 9fcd103) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580078. Important tips:
|
Message from Xin Zhang: Patch Set 17: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 17: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 17: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-07T10:13:42Z","revision":"c9bbd96abc95fb19a3eca9005b1b474d14dd5280"} Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 17: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 17: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Go LUCI: Patch Set 17: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Xin Zhang: Patch Set 17: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from qiu laidongfeng2: Patch Set 17: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Xin Zhang: Patch Set 17: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Xin Zhang: Patch Set 17: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Message from Xin Zhang: Patch Set 17: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580078. |
Hi All,
The issue this PR tries to solve is that when private/public key size is zero, and use the private key to sign a token or public key to verify, it returns an error:
crypto/rsa: message too long for RSA key size
, which does not reflect the root cause.The solution in the PR is to check the private/public key size before using the private/public key, and returns the error
crypto/rsa: private/public key size zero
if the private/public key size is zero to have a better error information and help to investigate.