-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: delay calling the Lock function in Register #67396
Conversation
This PR (HEAD: 9d5f3bf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/585855. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/585855. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/585855. |
Calling Lock when we need to access drivers variable to avoid meaningless locks
9d5f3bf
to
e312f6e
Compare
This PR (HEAD: e312f6e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/585855. Important tips:
|
Message from theratliter theratliter: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/585855. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/585855. |
Calling
Lock
when we need to accessdrivers
variableto avoid meaningless lock.