Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add %GDSEARCH% #1645

Open
ceed0 opened this issue May 24, 2023 · 4 comments
Open

Add %GDSEARCH% #1645

ceed0 opened this issue May 24, 2023 · 4 comments

Comments

@ceed0
Copy link

ceed0 commented May 24, 2023

From xiaoyifang/goldendict-ng#417

I can copy that pull request here, but I don't know Qt enough to tell if it's good.

@nonwill
Copy link

nonwill commented May 24, 2023

xiaoyifang/goldendict-ng#417 is not a good extensible implementation.
Maybe the Compound expressions feature which has been around there for a long time is exactly what you need:
handict_web_file111
Doing so does not need to make a big fuss to satisfy someones' desire. And of course, it is also possible to do these jobs in a Program dictionary by caching search history.

@vedgy
Copy link
Member

vedgy commented May 24, 2023

From xiaoyifang/goldendict-ng#417

I can copy that pull request here, but I don't know Qt enough to tell if it's good.

The file globalbroadcaster.h modified by that PR has been introduced in goldendict-ng and is not present here. So it's not a simple matter of copying.

@ceed0
Copy link
Author

ceed0 commented May 24, 2023

Compound expressions

This feature won't work with Japanese because sentences there have no spaces.
For Japanese something like mecab or marisa has to be used. Of course that could be integrated in goldendict, but it would probably require more work.

The file globalbroadcaster.h modified by that PR has been introduced in goldendict-ng and is not present here. So it's not a simple matter of copying.

Ah, right, I should've checked first.

@nonwill
Copy link

nonwill commented May 25, 2023

Compound expressions

This feature won't work with Japanese because sentences there have no spaces.

Yes, for Japanese, and also Chinese... something like built-in word segmentation function is very necessary and a more general implementation can be done on the basis of Compound expressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants