Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky groups per tabs #84

Open
ryrych opened this issue Feb 27, 2012 · 17 comments
Open

sticky groups per tabs #84

ryrych opened this issue Feb 27, 2012 · 17 comments

Comments

@ryrych
Copy link

ryrych commented Feb 27, 2012

Now we have a kind of a global search engine for all tabs. Assume that I have three open tabs and I have three groups respectively: en-en, en-pl, pl-en.

For instance, I’m looking up ‘lay out money’.

• I choose en-en and type it.
• open new tab, switch to en-pl, type it
• open new tab (pl-en) - it is auxiliary one

Now the group menu is at ‘pl-en’. But I would like to look up another word. To do this I have to change group menu all the time.
What if we had so-called sticky group per tab. That is. The group should remain the same until you change in – just like when you have only one tab/no tabs.

If I have to look up many words, it is very unwieldy to change it all the time.

@Tvangeste
Copy link
Member

It is worth noting that not only the groups selector should have per-tab state, but also the translate line and the suggestions list.

This is bad:
image

@Ansa211
Copy link

Ansa211 commented Feb 15, 2015

Is there any voting system for the feature requests? This would be my number one wish!

@mihaaly
Copy link

mihaaly commented Dec 15, 2022

Is there any voting system for the feature requests? This would be my number one wish!

+1

@SDPMrem71
Copy link

+1, yes I'd love it. 😍
(sorry if i was intrusive)🥹🥺

@nonwill
Copy link

nonwill commented Dec 15, 2022

@SDPMrem71 Just as this?
handict_web_file111

@SDPMrem71
Copy link

@nonwill I kinda don't understand from that picture, it has two tabs with two search. are they using separate dic?
I created a Image Explaining Expectation vs Reality. Please take a look. ❤️💕

Untitled-1-Recovered

@nonwill
Copy link

nonwill commented Dec 16, 2022

two tabs with two search. are they using separate dic?

@SDPMrem71 Yes. Just as your Explaining Expectation, Tab1(cabbage) uses "Apple's OSX" dict and Tab2(best) uses "E-英汉ESL" dict:

Tabs are switched without losing their contextual content.

@SDPMrem71
Copy link

SDPMrem71 commented Dec 16, 2022

Yes that is.

I share my understanding of your link so other people like me who don't know Chinese find it faster.

GoldenDict++OCR Deployment is

This is improved build over the official.

and in

2020.10.21 2A14;优化辞书群组列表、候选词列表、搜索框文字和Tab页切换的联动实现(切换Tab页不会丢失其上下文内容)

2020.10.21 2A14; Optimize the linkage implementation of the dictionary group list, candidate word list, search box text and tab page switching (switching the tab page will not lose its context content)

This feature was added. if you don't want to wait for official build to include this feature, try that since i have not yet.(good luck🥲)

@vedgy
Copy link
Member

vedgy commented Dec 17, 2022

@nonwill's fork is proprietary and illegal. Use at your own risk. See #1424.

@nonwill
Copy link

nonwill commented Dec 17, 2022

For GoldenDict++OCR, I've been eagerly waiting for ghost who also named marreromarco and some other shit words, and also his pals active there or here, to find bugs or spyware issues and post them publickly so to help us to improve GD/++, but nothing returned.

Among those opinions, only @vedgy is pertinent and got my approval. So Use at your own risk.

@SDPMrem71
Copy link

SDPMrem71 commented Dec 17, 2022

@nonwill whether your app is malware or not. it certainly violate owner wishes but your circumstance lead you to believe you can do it. Fine.

From what i have seen you kept the name, you are active and you don't take credit for what's not yours at least in international community or what i have come to know, everyone has to live somehow (try to earn from your hardwork) But here's a my advice or suggestion for you:

Nothing stays forever, every application has it's golden time. I come from babylon -> lingoes -> goldendic , in future i might even go to another platform (i found yours from goldendict too) SO try to give something BACK.

Staying here promoting your work doesn't help goldendict get bigger especially since your site is a headache to get around, even if you don't want to share source code try to respect wishes of "open code" and contribute to growth of official golden dict.

@nonwill
Copy link

nonwill commented Dec 17, 2022

Thanks for your pertinent criticism and suggestions. I have no goal of fame or fortune in maintaining the private one and that's why I don't bother with the controversy associated with it. So, it will definitely still be closed source for a while in the future.
But of course, I hope the official version of GD will become better and better, and more and more people will use the official one instead of the defective version such as #1447 driven by profit or others. For the official one, personally, the WebEngine fork/pr maintainied by @vedgy is stongly recommended.

@SDPMrem71
Copy link

SDPMrem71 commented Dec 17, 2022

sticky groups per tabs or separate dic per tab

Is also supported in xiaoyifang fork.
If anyone has trouble or don't want to use GD++, use this.

@vedgy is it ok if i create new pull from his repository to this? ( although if i could find it 😁)

@nonwill
Copy link

nonwill commented Dec 17, 2022

is it ok if i create new pull from his repository to this? ( although if i could find it

@SDPMrem71: Congratulations on picking the rose😁.

@vedgy
Copy link
Member

vedgy commented Dec 17, 2022

@vedgy is it ok if i create new pull from his repository to this?

The license is identical, so that shouldn't be a problem. But be prepared to fix issues found during code review. Or try to convince @xiaoyifang to fix them :)

@xiaoyifang
Copy link
Contributor

sticky groups per tabs or separate dic per tab

Is also supported in xiaoyifang fork.

not yet. plan to implement this in xiaoyifang/goldendict-ng#531

@nonwill
Copy link

nonwill commented Apr 26, 2023

Please refer to #1616 and #1618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants