Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce proper error type #28

Open
gonzolino opened this issue May 26, 2021 · 2 comments
Open

Introduce proper error type #28

gonzolino opened this issue May 26, 2021 · 2 comments
Milestone

Comments

@gonzolino
Copy link
Owner

All errors currently returned by gotado are just plain errors. We need a proper error type for gotado that contains the error message, but also the http status code of the tado API. Errors should also properly wrap the underlying error.

@gonzolino gonzolino added this to the v1.0 milestone May 27, 2021
@gonzolino
Copy link
Owner Author

@gonzolino
Copy link
Owner Author

Remember that tado° actually returns a list of errors, see e.g.

{
  "errors": [
    {
      "code": "zone.schedule.awayConfig.missingSetting",
      "title": "User setting must be provided when auto adjust is false for heating zone."
    },
    {
      "code": "nullable",
      "title": "Property autoAdjust is required"
    }
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant