Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

dependencies clone error #18

Open
dution89630 opened this issue Apr 12, 2018 · 3 comments
Open

dependencies clone error #18

dution89630 opened this issue Apr 12, 2018 · 3 comments

Comments

@dution89630
Copy link

dependencies can not be download correctly

@nat42
Copy link

nat42 commented Apr 28, 2018

Cloned repo and got 1.3 GB of junk* :( that seemed pretty unnecessary for what seems to be a tiny library.

As dution89630 may suggest what resulted wouldn't build a VS project with CMake, .\dependencies\harfbuzz\src\ was missing 3 files: "hb-ot-shape-complex-use.cc", "hb-ot-shape-complex-use-table.cc" and "hb-ot-var.cc"

And the CMakeLists.txt file from Motive is broken -
"include\motive\spring_init.h" is misspelled as "include/motive/sprint_init.h" (who checks in a non-working make file?)

NB: while I'd like to report this on the google/motive project it seems issue reporting is not enabled there (hence reporting it upstream/here shall have to suffice I guess)

*do we really need java-cardboard in this immediate mode GUI library?! It accounted for like 400MB of the junk and seems really out of place.

@dution89630
Copy link
Author

Some links can not be reached. such as hyphenation-patterns, webp etc

@nat42
Copy link

nat42 commented May 2, 2018

Sorry then Dution89630, I think my issues may have been different, git cloned without any apparent issue with hyphenation-patterns or webp for me.

My copy of Harfbuzz turned out to have more missing files, but after patching these in from a zip of that project correcting the issue with motive's build above and the build of gumbo-parser as I detailed on issue #13 I was able to build and run the examples using Visual Studio (2017)

Edit: Also had to modify build of a dependency to disable treating errors as warnings as is already logged as an issue/workaround on that project (in case that may also help)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants