-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generateLicenses Task takes excessively long #168
Comments
I'm running into a similar issue with my project. Were you able to find a way to decrease the time this task takes? |
Same here. Its about ~21min on average for me |
Hi there! We are still experiencing this issue and the task run time has only continually gotten worse. We'd love to take a look and contribute back to the project if possible but wanted to make sure we have the correct approach. We think the issue is with this recursive method that can take 80+ minutes to execute. Line 116 in b635f8f
@caller9 and @rekire (since you were the last two committers on this plugin), would you be able to confirm? Also, noticing this part of the repo hasn't been getting much traction, @davidmotson, would you able to point us to how we can get some help on this issue? |
From my side I neither confirm nor deny this, since my focus shifted to Flutter. With my last changes I fixed in one hand the package's name detection (before it was in most cases just the technical package name) and a lookup for existing licenses to dedublicate licenses in the output file. To be honest I cannot remember all the details, but I think I just added some maps with a complexity of o(1) which should not make it significant slower. However I can confirm that the builds seems to trend to become slower, but my observation is not related to this plugin. |
Describe the bug
we apply the plugin
apply plugin: 'com.google.android.gms.oss-licenses-plugin'
app:genererateLicenses
task excessively longit increases our build times between 15-30 minutes (from 5 minutes)
To Reproduce
here are our dependencies
sdkDependencies.txt
Expected behavior
Screenshots
Desktop (please complete the following information):
Gradle 6.8.3
com.google.android.gms:oss-licenses-plugin:0.10.2
Additional context
continues builds are fast but clean builds on CI are every single time extremely slow
The text was updated successfully, but these errors were encountered: