New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.3.10 does not add a google-services data to AAB files, but adds google-services data to APK files #225
Comments
anthonymonori
added a commit
to thirdwavelist/android
that referenced
this issue
May 15, 2022
The `google-services` plugin is plagued with issues if you are on the latest tooling features. For example it has issues [with configuration caching on](https://issuetracker.google.com/issues/221191604), [when used in conjunction with latest Gradle](google/play-services-plugins#221), [not adding expected output in AAB files](google/play-services-plugins#225), [and so on...](https://github.com/google/play-services-plugins/issues). The latest version of **4.3.10** was last released on [August 09, 2021](https://developers.google.com/android/guides/releases#august_09_2021). Generally speaking, committing the metadata generated (or the json itself) has been debunked many times now to be more friction to developers than actually being useful in securing your application. I recommend this article by Martin Bonnin to understand this a bit more: https://blog.mbonnin.net/about-the-android-makers-app-security-and-google-servicesjson Note: I've made sure to implement platform restrictions on the keys used by the apps to ensure what services and which APIs can be used specifically by these signed apps. Since the `google-services` gradle plugin is open sourced, it was quite easy to recreate the behavior and just simply create the xml entries manually from the `google-services.json` instead: https://github.com/google/play-services-plugins/blob/56c2c5609ee5d1ee9e3cd925a08f31ab4ecd3372/google-services-plugin/src/main/groovy/com/google/gms/googleservices/GoogleServicesTask.java This PR: - Removed the `google-services` plugin and the associated entries in `libs.versions.toml` - Removed the google-services.json files - Removed redundant gitignores - Added values from google-services.json into relevant debug|release\res\values\strings.xml Signed-off-by: Antal János Monori <anthonymonori@gmail.com>
anthonymonori
added a commit
to thirdwavelist/android
that referenced
this issue
May 15, 2022
The `google-services` plugin is plagued with issues if you are on the latest tooling features. For example it has issues [with configuration caching on](https://issuetracker.google.com/issues/221191604), [when used in conjunction with latest Gradle](google/play-services-plugins#221), [not adding expected output in AAB files](google/play-services-plugins#225), [and so on...](https://github.com/google/play-services-plugins/issues). The latest version of **4.3.10** was last released on [August 09, 2021](https://developers.google.com/android/guides/releases#august_09_2021). Generally speaking, committing the metadata generated (or the json itself) has been debunked many times now to be more friction to developers than actually being useful in securing your application. I recommend this article by Martin Bonnin to understand this a bit more: https://blog.mbonnin.net/about-the-android-makers-app-security-and-google-servicesjson Note: I've made sure to implement platform restrictions on the keys used by the apps to ensure what services and which APIs can be used specifically by these signed apps. Since the `google-services` gradle plugin is open sourced, it was quite easy to recreate the behavior and just simply create the xml entries manually from the `google-services.json` instead: https://github.com/google/play-services-plugins/blob/56c2c5609ee5d1ee9e3cd925a08f31ab4ecd3372/google-services-plugin/src/main/groovy/com/google/gms/googleservices/GoogleServicesTask.java This PR: - Removed the `google-services` plugin and the associated entries in `libs.versions.toml` - Removed the google-services.json files - Removed redundant gitignores - Added values from google-services.json into relevant debug|release\res\values\strings.xml Signed-off-by: Antal János Monori <anthonymonori@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I upgraded
com.google.gms.google-services
from4.3.5
to4.3.10
, and now mybundleRelease
build crashes on startup with the following:I then reverted back to
4.3.8
and mybundleRelease
build works fine.To Reproduce
Steps to reproduce the behavior:
.aab
filegoogle-services.json
:Expected behavior
My apk key should exist in my
.aab
file, just like it exists when I build a.apk
file directly:Desktop (please complete the following information):
From the Android Studio about screen:
Other versions:
The text was updated successfully, but these errors were encountered: