Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Ability to set the theme in code / Make OssLicensesMenuActivity extendable #251

Open
gmikhail opened this issue Nov 19, 2022 · 1 comment

Comments

@gmikhail
Copy link

My app uses two themes (dark and light). After applying the new theme, I need to apply the new theme dynamically in activities via setTheme in onCreate. But I can't set the theme in OssLicensesMenuActivity via code. Only set statically in the manifest:

 <activity
            android:name="com.google.android.gms.oss.licenses.OssLicensesMenuActivity"
            android:theme="@style/AppThemeDark" />

It would be nice to be able to set the theme in code. Something like this:

OssLicensesMenuActivity.setActivityTheme(R.style.AppThemeDark);

Or at least make OssLicensesMenuActivity not final so it can be extended.

@alwa
Copy link

alwa commented Nov 19, 2022

Somewhat related: google/accompanist#1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants