Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FyberMediationAdapter: NPE in onConfigurationReadyAndValid #213

Open
too-far-away opened this issue Feb 5, 2020 · 3 comments
Open

FyberMediationAdapter: NPE in onConfigurationReadyAndValid #213

too-far-away opened this issue Feb 5, 2020 · 3 comments

Comments

@too-far-away
Copy link

After integrating Fyber adapter in AdMob mediation we observe application crashes in FyberMediationAdapter. It probably happens when initialization takes longer and does not finish by the time ads start showing.
The crash happens in onConfigurationReadyAndValid when the completionCallback passed in waitForInitializationStatusAndReport is null, although annotated as non null.
The null value for this parameter does get there in case the call chain starts (for example) with requestBannerAd, which calls initializeFromBundle, which in turn calls initialize passing null in the callback argument. Finally, waitForInitializationStatusAndReport adds configuration readiness listener with no callback and sometimes this event fires twice, while the first time it was set up with the callback supposedly by AdMob initialization, and the second time after requestBannerAd was called and thus the callback is null there.
Sometimes, the event fires only once, and then everything works, so maybe the real issue is in the configuration manager.

@kapyar
Copy link

kapyar commented Feb 6, 2020

I know it might not help but Fyber is going to shut down on March. Dont think it will be priority for the team to fix issues for that provider

@too-far-away
Copy link
Author

I maybe wrong, but as I understand they close their current mediation platform, moving applications with DAU>25K to a new platform they call Fyber FairBid. Unless they are shutting down their business...

@mathieubouissiere
Copy link

@kapyar , Fyber is not shutting down. We are shutting down legacy products in March which is not related to the product mentioned by @not-there-yet.
The product we are talking about here in this thread is Fyber Marketplace under AdMob mediation:
https://www.fyber.com/fyber-marketplace/
Regarding Fyber FairBid: https://www.fyber.com/meet-the-new-fyber-fairbid/, you are correct it's our new platform / mediation product.
Just to clarify :)
Regarding the issue I will have a look and get back to you, we have also an email thread on which I will answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants