Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Self-XSS in "Absolute Time Range" #2746

Open
takyoni opened this issue Apr 13, 2022 · 3 comments
Open

[BUG] Self-XSS in "Absolute Time Range" #2746

takyoni opened this issue Apr 13, 2022 · 3 comments
Labels

Comments

@takyoni
Copy link

takyoni commented Apr 13, 2022

Describe the bug
It's possible to execute JS on application context by modifying the "Absolute Time Range"

To Reproduce
Access to a new dashboard in graphite-web instance (i.e. http://localhost/dashboard).
Use the "Absolute Time Range"
Write in Start Date:
<img src=1 onerror=alert()>
Write in EndDate:
<img src=1 onerror=alert()>
Hover the mouse over these fields
Expected behavior
This can be solved by removing or ignoring requests containing the characters "<" ">" and/or other escaping/scripting characters. -> Sanitize the value before using it.

Screenshots
Снимок экрана (2046)
Снимок экрана (2047)

Environment (please complete the following information):

  • OS flavor: Debian 11
  • Graphite-web version 1.1.8
  • Setup type: docker
@deniszh
Copy link
Member

deniszh commented Nov 6, 2022

Looks like not fixed in #2785 :(
/cc @msaf1980

@msaf1980
Copy link
Contributor

msaf1980 commented Nov 7, 2022

@deniszh I already update our staging (and production today). Now I can't reproduce a issue (and can before update). No alert window in web front and dangerous symbols are escaped.

@msaf1980
Copy link
Contributor

As I think, bug in ExtJS DateField.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants