Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] graphite-web 1.1.8+ dependency on pyparsing misses version requirement #2834

Open
timmooney opened this issue Apr 18, 2024 · 0 comments
Labels

Comments

@timmooney
Copy link

I'm attempting to update a working install of whisper/carbon/graphite-web from 1.1.5 to current latest. Once I'm on a more recent version, I'll be moving my install to a newer system & Python3, but for now I have to get the current version upgraded.

My working install with 1.1.5 is using pyparsing 2.2.0.

I've discovered that graphite-web 1.1.8 and 1.1.10 will not work with that version of pyparsing. At 1.1.8 webapp/graphite/render/grammar.py goes away and is replaced by webapp/graphite/render/grammar_unsafe.py.

The new grammar_unsafe.py still uses pyparsing, but its import now also requires pyparsing_unicode.

pyparsing_unicode was introduced in pyparsing version 2.3.0. See: pyparsing CHANGES

It looks like the requirements.txt file was updated to note the dependency (for pip, I assume?), but other places were not.

Two things should be updated:

  1. The Dependencies documentation for graphite should be updated to list pyparsing >= 2.3.0. Currently other python module dependencies are mentioned, but pyparsing isn't listed at all.
  2. The check_dependencies.py script is checking for any version of pyparsing and isn't detecting an installed version that predates pyparsing_unicode.

I'm not wise in the ways of Python, but it's possible the tox.ini also may need updates?

@timmooney timmooney added the bug label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant