Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rendering of shop=jewellery (but keep jewelry) #4962

Open
HolgerJeromin opened this issue May 3, 2024 · 2 comments
Open

Remove rendering of shop=jewellery (but keep jewelry) #4962

HolgerJeromin opened this issue May 3, 2024 · 2 comments

Comments

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented May 3, 2024

https://wiki.openstreetmap.org/wiki/Tag:shop%3Djewellery
has been deprecated but the single existing node in the osm database is still rendered:

https://www.openstreetmap.org/node/10798568929

image

I have no rendering stack available, so I could only do a blind fix.

Ref deprecation in iD editor since 2019:
openstreetmap/iD#6266

@imagico
Copy link
Collaborator

imagico commented May 3, 2024

In general i am wary about removing support for tags that have gone out of use due to mechanical edits (and potentially subsequent suppression of continued use by self appointed tagging police).

In this case, however - while the reduction to almost zero use is largely due to a mechanical edit in late 2022 - the tag has never had wide adoption in the first place with peak use in 2018 being around 350 while the competing tag back then had already about 100 times as much use. Hence i would be in support of removing this .

@pnorman
Copy link
Collaborator

pnorman commented May 10, 2024

I'm fine with how it was removed from the DB so it should removed. This is a good first issue - anyone picking it up just be search to search the code for all occurrences of jewellery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants