Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong tld expression #1070

Closed
teramako opened this issue Dec 27, 2009 · 2 comments
Closed

Wrong tld expression #1070

teramako opened this issue Dec 27, 2009 · 2 comments
Milestone

Comments

@teramako
Copy link

A part of TLD regexp string is wrong.

http://github.com/greasemonkey/greasemonkey/blob/master/content/convert2RegExp.js#L45

var reg = convert2RegExp("http://google.tld");
reg.test("http://googleAcom") // returns true, although should return false

The string of "tldStr" variable should start from "\." not "."

@erikvold
Copy link
Contributor

I tested this and teramako is correct.

I've patched my clone http://github.com/erikvold/greasemonkey/commit/f579a1e4f8b8b3485077a6ac4b97fc5a94e470ac

E

@arantius
Copy link
Collaborator

arantius commented Apr 2, 2010

commit abcd057

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants