Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert2RegExp missing case "}" #1074

Closed
erikvold opened this issue Jan 24, 2010 · 5 comments
Closed

convert2RegExp missing case "}" #1074

erikvold opened this issue Jan 24, 2010 · 5 comments
Milestone

Comments

@erikvold
Copy link
Contributor

Hey,

I think that the convert2RegExp function is missing the case "}".

Erik

@arantius
Copy link
Collaborator

Can you be a bit more specific ?

@erikvold
Copy link
Contributor Author

The convert2regexp has a switch statement, the switch statement is missing the case statement for "}" because a "}" needs to become "}" as is aleady done with "{" already

Otherwise the pattern string "http://abc{3}" would become /^http://abc{3}$/

@erikvold
Copy link
Contributor Author

hmmm /^http://abc{3}$/ still seems to work as a regular expression it seems, on FF3.6 at least, so maybe it's not an issue after all..

@erikvold
Copy link
Contributor Author

It looks like "}" and "]" cases are treated similarly, so either we should handle the "}" case or not handle the "]" case to be consistent.

@arantius
Copy link
Collaborator

arantius commented Apr 2, 2010

commit f115f8e

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants