Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @version #1110

Closed
erikvold opened this issue May 11, 2010 · 11 comments
Closed

Support @version #1110

erikvold opened this issue May 11, 2010 · 11 comments
Milestone

Comments

@erikvold
Copy link
Contributor

Just read the @Version header which us.o uses, and display it in the addon manager.

@sizzlemctwizzle
Copy link
Contributor

Sounds good. Put it by the user script name with a little padding like is done with addons?

@erikvold
Copy link
Contributor Author

Yep, I've already got a commit for it, I've just got to cherry pick it on to a new branch so that it can be pulled. Working on that atm..

@erikvold
Copy link
Contributor Author

Alright here it is. Cherry picking is so easy! I love git.

@arantius
Copy link
Collaborator

Cherry picking is not easy when you have to cherry pick many commits to get the whole change. Branches are easy. But it looks like you really made a branch anyway.

Please include in this branch some code to, upon upgrade to 0.9.0 (should be handled by the built in upgrading logic, just for the new version) actually parse out the version data from any already installed scripts.

@erikvold
Copy link
Contributor Author

Cherry picking is not easy when you have to cherry pick many commits to get the whole change.

Yes, it only works for one commit at a time. It's easy for the task that it was designed for.

Branches are easy. But it looks like you really made a branch anyway.

Yes, I made a branch then cherry picked the commit from my eriks-addonstab branch.

@erikvold
Copy link
Contributor Author

Please include in this branch some code to, upon upgrade to 0.9.0 (should be handled by the built in upgrading logic, just for the new version) actually parse out the version data from any already installed scripts.

I wonder if this should be a separate issue that should be generalized for use whenever a new @Header is added.

@sizzlemctwizzle
Copy link
Contributor

I wonder if this should be a separate issue that should be generalized for use whenever a new @Header is added.
Well its not like we added these incredibly often. Plus the code already use for the live meta can be reused.
Please include in this branch some code to, upon upgrade to 0.9.0 (should be handled by the built in upgrading logic, just for the new version) actually parse out the version data from any already installed scripts.
Patched with this commit.

@Martii
Copy link
Contributor

Martii commented May 11, 2010

What if @Version is missing from an existing, super old script (or even a new one)?

@sizzlemctwizzle
Copy link
Contributor

What if @Version is missing from an existing, super old script (or even a new one)?
An empty string(aka "") is used, which is how a lot of header values are handled when they are missing in a script. Therefore, nothing will be displayed next to the script name in the scripts addons dialog.

@sizzlemctwizzle
Copy link
Contributor

This commit allows the @Version to be reread when the user modifies the file. So you can merge with this branch to get all the changes.

@arantius
Copy link
Collaborator

commit 0dae74a

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants