New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support @version #1110
Comments
Sounds good. Put it by the user script name with a little padding like is done with addons? |
Yep, I've already got a commit for it, I've just got to cherry pick it on to a new branch so that it can be pulled. Working on that atm.. |
Alright here it is. Cherry picking is so easy! I love git. |
Cherry picking is not easy when you have to cherry pick many commits to get the whole change. Branches are easy. But it looks like you really made a branch anyway. Please include in this branch some code to, upon upgrade to 0.9.0 (should be handled by the built in upgrading logic, just for the new version) actually parse out the version data from any already installed scripts. |
Yes, it only works for one commit at a time. It's easy for the task that it was designed for.
Yes, I made a branch then cherry picked the commit from my eriks-addonstab branch. |
I wonder if this should be a separate issue that should be generalized for use whenever a new @Header is added. |
I wonder if this should be a separate issue that should be generalized for use whenever a new @Header is added.Well its not like we added these incredibly often. Plus the code already use for the live meta can be reused. Please include in this branch some code to, upon upgrade to 0.9.0 (should be handled by the built in upgrading logic, just for the new version) actually parse out the version data from any already installed scripts.Patched with this commit. |
What if @Version is missing from an existing, super old script (or even a new one)? |
What if @Version is missing from an existing, super old script (or even a new one)?An empty string(aka "") is used, which is how a lot of header values are handled when they are missing in a script. Therefore, nothing will be displayed next to the script name in the scripts addons dialog. |
This commit allows the @Version to be reread when the user modifies the file. So you can merge with this branch to get all the changes. |
commit 0dae74a |
Just read the @Version header which us.o uses, and display it in the addon manager.
The text was updated successfully, but these errors were encountered: