Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting user scripts in about:addons by desc execution order #1217

Closed
wants to merge 1 commit into from
Closed

sorting user scripts in about:addons by desc execution order #1217

wants to merge 1 commit into from

Conversation

erikvold
Copy link
Contributor

@erikvold erikvold commented Nov 4, 2010

At the moment we can only order user scripts by ascending execution order but not descending.

@arantius
Copy link
Collaborator

arantius commented Nov 4, 2010

This was fully intentional. At least in Firefox 4.0b6 on Linux, there is absolutely no visual indicator of the sort order (asc/desc). For name and date, you can read the values and derive the sort order. But execution order is completely invisible except for the sorting, so I made it consistently "runs first is on top".

Do we have any third person with an opinion of which way it should be?

@sizzlemctwizzle
Copy link
Contributor

Do we have any third person with an opinion of which way it should be?
I agree with arantius. If we allow the list to be sorted by asc/desc, it isn't at all obvious what state the list is currently in. Makes more sense for the order to be constant in this case.

@erikvold
Copy link
Contributor Author

Go to about:addons then do a search for "restart" then sort by "best match"; it's the same issue (for lack of a better word) that you describe.

it isn't at all obvious what state the list is currently in.

The sort type is selected, and there is an arrow indicating if the sort is ASC or DESC

At least in Firefox 4.0b6 on Linux, there is absolutely no visual indicator of the sort order (asc/desc).

On OSX I see an arrow (afair windows too), there must be one coming for Linux if it's not there already.

File a bug if it's not there in a later version.

@sizzlemctwizzle
Copy link
Contributor

The sort type is selected, and there is an arrow indicating if the sort is ASC or DESC
The arrow isn't a good indicated whether the list is currently sorted in ASC or DESC order imo. This could just be me.

@arantius
Copy link
Collaborator

FWIW, with 4.0b7 on Linux I still don't see any sort arrows. On Mac, I do see them. The execution order one is only displayed descending, which feels backwards.

@erikvold
Copy link
Contributor Author

FWIW, with 4.0b7 on Linux I still don't see any sort arrows.

Make a bug, if it's a dup then you'll find the orig quickly.

The execution order one is only displayed descending, which feels backwards.

You lost me, the execution order is only displayed desc on GM master? or my patch?

@arantius
Copy link
Collaborator

You lost me, the execution order is only displayed desc on GM master? or my patch?

On Mac, with GM head, no patch, I see a sort arrow for execution order, but in the "wrong" direction. This boosts the priority of this bug. (Triangles for sort order are always ambiguous anyway, but the situation needs addressing.)

@arantius
Copy link
Collaborator

allow about:addons to sort user scripts by descending execution order

Closed by fbed342

@Martii
Copy link
Contributor

Martii commented Jan 26, 2011

See Minefield nightly

Mozilla/5.0 (X11; Linux x86_64; rv:2.0b11pre) Gecko/20110126 Firefox/4.0b11pre

upper right hand corner... try it out.

This does reissue #1180 though along with this one probably... and several others.

dept42 pushed a commit to dept42/greasemonkey that referenced this pull request May 12, 2011
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants