Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when using GM_notification on OSX with no Growl #1249

Closed
erikvold opened this issue Jan 20, 2011 · 5 comments
Closed

Errors when using GM_notification on OSX with no Growl #1249

erikvold opened this issue Jan 20, 2011 · 5 comments
Milestone

Comments

@erikvold
Copy link
Contributor

Some errors that I saw in the error console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)" location: "JS frame :: resource://greasemonkey/GM_notification.js :: <TOP_LEVEL> :: line 5" data: no]

Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: chrome://greasemonkey/content/scriptdownloader.js :: <TOP_LEVEL> :: line 60" data: no]

@erikvold
Copy link
Contributor Author

erikvold@ebe4d3fbfd34d32b4a02a01932791a882f6e0ae1

@erikvold
Copy link
Contributor Author

I'm -1 for using alert when the user is using osx without Growl for the 2 cases that it's currently being used fwiw.

@erikvold
Copy link
Contributor Author

I'm thinking that GM_logError should be used instead of using alert when the user does not have the nsIPromptService available. Unless there is a better idea, just my 2c.

@arantius
Copy link
Collaborator

Growl is not installed by default. Either we want users to see this information (use alert) or we don't (then why are we displaying it at all). Logging to the error console is as good as invisible to "real" users.

Alternatively: we'll go with alert. If users complain that it's annoying, perhaps we remove the alerts / just remove all this progress stuff.

@erikvold
Copy link
Contributor Author

Closed by aef88fd fixing errors in the Error Console when using GM_notification on OSX without Growl

dept42 pushed a commit to dept42/greasemonkey that referenced this issue May 12, 2011
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants