Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Personas extension #1253

Closed
torrie opened this issue Jan 22, 2011 · 13 comments
Closed

Incompatibility with Personas extension #1253

torrie opened this issue Jan 22, 2011 · 13 comments

Comments

@torrie
Copy link

torrie commented Jan 22, 2011

On my computer, the new script management window in the add-ons menu doesn't work.
It is blank (there are scripts installed).

I opened the error console. Every time I opened the greasemonkey tab in the add-ons window, the following was added in the error-console:

Error: aRulesList is undefined
chrome://mozapps/content/extensions/extensions.js
Line: 200

@arantius
Copy link
Collaborator

Could you provide more details?

Operating system? Firefox version? Greasemonkey version?

Could you test in a fresh profile?

See: http://wiki.greasespot.net/Greasemonkey_Manual:Getting_Help#What_to_Say

@sizzlemctwizzle
Copy link
Contributor

Mostly likely the user has the All-in-One Sidebar addon installed. See the result with this screen shot. This issue is therefore a dupe of #1252.

@JC2k8
Copy link

JC2k8 commented Jan 24, 2011

I have the same issue. There is no All-in-One Sidebar addon installed.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13

Greasemonkey 0.9.0, obviously.

Screenshot: http://i.imgur.com/tCKxC.png

I'll try a fresh profile later.

// edit:

Creating a new profile fixed that issue.

@torrie
Copy link
Author

torrie commented Jan 24, 2011

Firefox 3.6.13
Windows 7 (x86)
GM 0.9.0

I had the personas addon installed. (which is unnessesary, because in Firefox 3.6, most of the personas functions are included in Firefox)
Uninstalling personas fixed the problem.

@arantius
Copy link
Collaborator

This and #1256 were helped by removing Personas. Renamed this issue to track compatibility with that extension.

@arantius
Copy link
Collaborator

This extension reproduces the behavior described, so I assume that's really what we're talking about: https://addons.mozilla.org/en-US/firefox/addon/personas-plus/

Of note, the error as posted occurs when switching to the User Scripts tab. Upon examination of the extension source, I find that they are extending the addons manager as well, but in a very different way, virtually guaranteed to cause a problem like this. They're simply overwriting core Firefox methods with their own modified copy.

I'm not confident we can work around this.

@arantius
Copy link
Collaborator

Stylish doesn't use showView() or any of the other standard machinery. They just bind a click handler. That's why arrow keys don't work quite right, as I posted to the list. (Also: click on any tab in the add-ons window: up and down arrows now select items in the list. Not for Stylish. Their method breaks that too.)

@sizzlemctwizzle
Copy link
Contributor

Whoops, deleted my comment when I saw you explain this on the dev group. Difficulties of discussing something in two places.

@arantius
Copy link
Collaborator

I've sent an email upstream about this, with no response. I don't know if/how much help we can rely on from elsewhere.

Since the problem is them clobbering the showView function after we extend it, we'll probably have to write a custom check for Personas, and re-extend (what is now their version) a second time.

(If I find some time, I'll look at Bugzilla, which might be the place to complain upstream.)

@chimericdream
Copy link

I am having the same issue, but I do not have Personas installed. Looks like the incompatibility applies (as someone has already mentioned) to the All-in-One sidebar mod as well. Any chance of looking into a patch?

@arantius
Copy link
Collaborator

AioS has a fix in the pipeline. Try out their betas:
http://firefox.exxile.net/forum/viewtopic.php?f=1&t=15277

@chimericdream
Copy link

Awesome, thanks!

@arantius
Copy link
Collaborator

Work-around for Personas Plus' breakage.

Closed by 1626b4f

dept42 pushed a commit to dept42/greasemonkey that referenced this issue May 12, 2011
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants