New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GM_xmlhttpRequest really needs a synchronous mode. #1269
Conversation
Eh, obvious security bugs, didn't read the setupRequestEvent properly. There shouldn't be security issues now. |
why is a synchronous mode needed? it's a terrible thing to do.. |
Because asynchronous requests aren't always the best way, and I don't see why not giving the developer the chance to use synchronous requests. |
when is it not? |
In my case I had to try multiple lyrics website one after another if the previous failed, and setting up it to work with asynchronous requests would be an useless overengineering when there's synchronous mode. |
It's not useless.. synchronous xhr locks the ui, asynchronous requests do not lock the ui.. |
It doesn't lock the UI for me. And once again, leave the choice to the developer. |
That right, the possibility to have a synchronous mode for the function GM_xmlhttprequest will really help the developers. In some case, it can be very usefull. That why as meh said, leave the choice to the developer is a great solution. Thanks. |
Conflicts: content/xmlhttprequester.js
Conflicts: content/xmlhttprequester.js Fixes: greasemonkey#1269
In at least some circumstances, this is currently failing with Test case: https://gist.github.com/1134362 |
Working on |
Also working: So, failing in 3 only, working in 4+. |
Shouldn't be a problem to merge to master.
Or reimplement it in some other way, this was just a fast hack to get something I needed working.
Thanks.