Use the fileName / lineNumber parameters to evalInSandbox()

[arantius]

From: #1396
See: #1396 (comment)

Couldn't we use the last two arguments for Components.utils.evalInSandbox detailed here?

So the call in modules/runScript.js would look something like:

Components.utils.evalInSandbox(code, sandbox, maxJSVersion, filename, 1);

We could loop through all the @requires and eval each one individually, that way those filenames and line numbers are preserved as well. Then finally we would eval the script. Is there some reason this wouldn't work?

[arantius]

This would probably involve un-doing the "first line eval" module I added in #1396, because it would be obsolete.

[arantius]

First attempt:
arantius/greasemonkey@master...eval-file-lines-1404

Promising, but currently failing bad in Firefox 3.

[arantius]

Also: https://gist.github.com/1154205

A test script that just triggers a variety of error conditions. Feedback please if you know of other failure modes, especially ones that are handled poorly by current error reporting logic. In Firefox 4+ my existing branch seems to handle all these cases. Including (quite surprisingly) the old "var sidebar;" thing that made us keep wrapper functions last time.

[arantius]

This may be obsoleted by webby execution mode (see 1.0 milestone).