Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"window is not defined" in getEditor #1409

Closed
Ventero opened this issue Aug 29, 2011 · 0 comments
Closed

"window is not defined" in getEditor #1409

Ventero opened this issue Aug 29, 2011 · 0 comments
Milestone

Comments

@Ventero
Copy link
Contributor

Ventero commented Aug 29, 2011

As a result of moving getEditor into its own module, it doesn't have access to window in the call to filePicker.init anymore, which currently makes it impossible to choose an editor via the UI.

Steps to reproduce:

  1. Open the Greasemonkey preferences
  2. Click "Change Editor"

Expected result: File picker dialog to choose an editor opens
Observed result: Nothing happpens

As the docs say, the first parameter to filePicker.init has to be non-null, so I have no idea if there's a better fix than to just pass window through every call to openInEditor and getEditor.

Ah, missed util/getBrowserWindow.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants