Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Available Updates' tab shows the currently installed script version, not the updated version #1497

Closed
mjh563 opened this issue Jan 9, 2012 · 3 comments
Milestone

Comments

@mjh563
Copy link

mjh563 commented Jan 9, 2012

  1. Load the Add-ons Manager
  2. Select "Check for updates" from the button menu
  3. Any add-ons and/or userscripts with updated versions are shown in the "Available Updates" tab

One slight inconsistency here is that the version number shown for add-ons is the new version, whereas the version number shown for userscripts is the currently installed version. See this screenshot:

http://i1091.photobucket.com/albums/i383/mjh563/availableupdates.png

The YouTube userscript is being updated from 1.3.5 to 1.3.6, but shows the current version (1.3.5), whereas the add-ons that are being updated show the version they'll be updated to. For example, here Adblock Plus is being updated from 2.0.2 to 2.0.3.

@arantius
Copy link
Collaborator

arantius commented Jan 9, 2012

I'll need to confirm but the behavior I remember is:

This is just how Firefox works. Find a restartless extension, install an old version, turn off the "Update add-ons automatically" option, and manually check for updates. You'll then see the available updates tab, and it will behave this exact way.

@arantius
Copy link
Collaborator

arantius commented Feb 6, 2012

I did:

  1. Visit https://addons.mozilla.org/en-US/firefox/addon/fox-splitter/versions/
  2. Install version 2.0.2011090101
  3. Restart Firefox to be safe
  4. Open add-ons manager
  5. Check for updates in the "wrench" ish drop down button
  6. Everything just installed immediately.

This in Mozilla/5.0 (X11; Linux i686 on x86_64; rv:11.0) Gecko/20100101 Firefox/11.0. This is the default behavior. If I repeat this, but after step 4 I open the detail page for this extension and turn Automatic Updates to Off, only then does the 'available updates' tab appear. And I can confirm that the new version (the one that would be installed by the update, not the installed version) is indeed what appears here. I can't reproduce the bit for user scripts because at the moment, there is no "available updates" feature (in #1053 found updates became installed automatically). So this should happen as part of #1455, which would bring it back.

@arantius arantius closed this as completed Feb 6, 2012
@arantius
Copy link
Collaborator

As correctly pointed out on the -dev list ( https://groups.google.com/d/topic/greasemonkey-dev/2cp4VLDSjWo/discussion ) now that update handling is "fixed" to be internally consistent (as of 1.4) this bug exists again and is fixable.

@arantius arantius reopened this Oct 17, 2012
arantius added a commit to arantius/greasemonkey that referenced this issue Oct 17, 2012
Instead make "availableUpdate" the parsed script when it was determined to be a valid update.  (To support coming fix for greasemonkey#1497.)
arantius added a commit to arantius/greasemonkey that referenced this issue Nov 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants