Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM_openInTab sometimes opens tabs in wrong window #1758

Closed
Y0ba opened this issue Jul 8, 2013 · 1 comment
Closed

GM_openInTab sometimes opens tabs in wrong window #1758

Y0ba opened this issue Jul 8, 2013 · 1 comment
Milestone

Comments

@Y0ba
Copy link

Y0ba commented Jul 8, 2013

STR:

  1. Install script https://gist.github.com/Y0ba/a2b623d4f30bb814d192
  2. Open https://github.com/greasemonkey/greasemonkey
  3. Drag tab down, so it creates a new window
  4. Click link

GM_openInTab opens new tab in the first window, but should open after the tab where it was called.

See this gif:
Greasemonkey Bug

@Ventero
Copy link
Contributor

Ventero commented Jul 8, 2013

https://github.com/Ventero/greasemonkey/tree/issue1758 contains a fix for this issue, as well as a semi-related commit (which stops unnecessarily passing a chrome window to GM_rmc).

Strictly speaking, something similar has to be done for the firebug console, if one was detected during load. However, as Firebug creates a new console instance when the content window is moved, this would require checking for a new Firebug console during every call to console.{log,warn,...}, so I'm not sure if this should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants