New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert http-USO to https-USO to enable updating #1800
Conversation
Several scripts are stuck at an old version because their downloadURL points to the http-version of USO instead of https, while extension.greasemonkey.requireSecureUpdates is set to true by default. Since it is known in advance that USO is able to server content over https, we can safely convert all USO downloadURLs to the https-version.
Thanks for your suggestion! I decided to implement this by using the setters for those properties. |
@arantius Unfortunately, the feature has not been implemented correctly. I followed the following steps:
What I expected was that the "Find updates" context menu entry was available, and on click it should get the latest version of the user script from USO. You've fixed the behavior for new scripts, but old scripts are still affected. That's why I added a special case-check for USO to your source code. |
Can you confirm exactly which script you were testing with? |
I've tested the feature with http://userscripts.org/scripts/version/112070/619679.user.js (released in July, see To verify the bug, you can take any script that has an old release with a http- |
Confirmed that specifically an "old version" from us.o does not behave as expected. Thanks for the testing. I missed a few references to the private property being set directly, and have now fixed them. |
Confirmed to work as expected. I can still see a few references to
|
Thanks! There is indeed two other missed references in there. The rest are other objects with properties of the same name (or the actual setter/getter impl), which is why I missed any to begin with. Leaving this open to remember to come back and fix those too. |
Several scripts are stuck at an old version because their downloadURL points to the http-version of USO instead of https, while
extension.greasemonkey.requireSecureUpdates
is set to true by default.Since it is known in advance that USO is able to server content over https, we can safely convert all USO downloadURLs to the https-version.
The limitation that has been fixed affects over 6k scripts: