Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome privileges - userscripts work on about: pages (about:addons, about:healthreport...) #1988

Closed
janekptacijarabaci opened this issue Aug 5, 2014 · 3 comments
Milestone

Comments

@janekptacijarabaci
Copy link
Contributor

Ad #1375 (comment)

I don't know if this is a solution:
https://github.com/janekptacijarabaci/greasemonkey/tree/aboutBlank

@Ventero
Copy link
Contributor

Ventero commented Aug 5, 2014

A few questions on this general topic (let me know if I should take this to the mailing list):

  • We currently only run scripts on about:blank if they specifically request it (i.e., not if they only @include *. If I'm understanding the logic of this patch correctly, this changes it to only run if additionally, the about:blank window doesn't have any other (i.e. non-blank) about: ancestors. How about only allowing about:blank if it's the top level window? In many cases, frames start with an about:blank URI before having their location changed, and injecting about:blank scripts into those doesn't make too much sense.
  • What's the current consensus on allowing scripts to run on pages with chrome privileges? We do allow data/about URIs (which can have chrome privileges) if the user enables the preference. I assume allowing any chrome privileged URIs by default is a no-go?

@arantius
Copy link
Collaborator

arantius commented Aug 5, 2014

User scripts should never get chrome privileges.

Those preferences should probably be removed sooner than treating them as precedent to do anything.

@arantius arantius added this to the 2.2 milestone Aug 22, 2014
@janekptacijarabaci janekptacijarabaci changed the title Userscripts work on about: pages (about:addons, about:healthreport...) Userscripts work on about: pages (about:addons, about:healthreport...) - chrome privileges Aug 23, 2014
@janekptacijarabaci janekptacijarabaci changed the title Userscripts work on about: pages (about:addons, about:healthreport...) - chrome privileges Chrome privileges - userscripts work on about: pages (about:addons, about:healthreport...) Aug 23, 2014
@janekptacijarabaci
Copy link
Contributor Author

Chrome privileges:
See also #1302, #1375, #1767, #1917

Ad #1375 (comment):
This solves the implementation #1859 (perhaps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants