Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate legacy -> webext #2551

Closed
arantius opened this issue Aug 24, 2017 · 12 comments
Closed

Migrate legacy -> webext #2551

arantius opened this issue Aug 24, 2017 · 12 comments
Milestone

Comments

@arantius
Copy link
Collaborator

Migrate scripts/settings from legacy extension to a webext accessible location.

@arantius arantius added this to the 4.0 milestone Aug 24, 2017
@arantius
Copy link
Collaborator Author

https://stackoverflow.com/questions/45948501

Embedded webextensions are a thing, but not for us (?).

@ngyikp
Copy link

ngyikp commented Aug 30, 2017

It's possible to use embedded WebExtension for overlay add-ons: https://github.com/mdn/webextensions-examples/tree/master/embedded-webextension-overlay

@arantius
Copy link
Collaborator Author

Thank you for that link. Another example of Mozilla's documentation being disappointing.

@arantius
Copy link
Collaborator Author

arantius commented Sep 3, 2017

The point of this issue is to make it one, so the fact that it's not been closed should help you figure that out. I've just barely started work on this.

arantius added a commit to arantius/greasemonkey that referenced this issue Sep 5, 2017
Including new installs.  To do: use this port for set/delete'd values.

Refs greasemonkey#2551
@arantius
Copy link
Collaborator Author

arantius commented Sep 5, 2017

  1. Install developer edition ( https://www.mozilla.org/en-US/firefox/developer/ )
  2. Create a profile for testing
  3. Toggle xpinstall.signatures.required to false
  4. Install greasemonkey-2017.09.05.beta.xpi (including restart)
  5. Install any user script (preferably something that's easy to tell is running)
  6. Install greasemonkey-4.0alpha1.xpi

At this point I'd expect the webext alpha to have a script installed at this point, but no dice.

@StrikerFX
Copy link

Where can I find the download link of the two versions: greasemonkey-2017.09.05.beta and greasemonkey-4.0alpha1.xpi?

arantius added a commit to arantius/greasemonkey that referenced this issue Sep 7, 2017
For embedded migration testing.

Refs greasemonkey#2551
@hook321
Copy link

hook321 commented Sep 9, 2017

Will the non-webext version still be maintained and developed? Quite a few people still use it on Pale Moon.

@Sxderp
Copy link
Contributor

Sxderp commented Sep 10, 2017

@hook54321a, Since all the issues regarding GreaseMonkey <4.0 have been closed, I'd reckon the answer to that is no.

arantius added a commit to arantius/greasemonkey that referenced this issue Sep 13, 2017
For embedded migration testing.

Refs greasemonkey#2551
@arantius
Copy link
Collaborator Author

https://mail.mozilla.org/pipermail/dev-addons/2017-September/003151.html

I've got "working" code for this (all log messages are as expected), which doesn't work (data isn't actually migrated).

@arantius
Copy link
Collaborator Author

The failure mentioned above was arantius/greasemonkey@d94af37 . I've got one working end to end test of this now, so the plan is to clean it up, finalize a 3.x release and get it out ASAP.

@Sxderp
Copy link
Contributor

Sxderp commented Sep 13, 2017

The failure mentioned above was arantius/greasemonkey@d94af37 . I've got one working end to end test of this now, so the plan is to clean it up, finalize a 3.x release and get it out ASAP.

Rip. Just set up to test the problems. Anyway, at least it's resolved.

@arantius arantius modified the milestones: 4.0, 3.12 Sep 13, 2017
arantius added a commit to arantius/greasemonkey that referenced this issue Sep 13, 2017
arantius added a commit to arantius/greasemonkey that referenced this issue Sep 13, 2017
arantius added a commit to arantius/greasemonkey that referenced this issue Sep 13, 2017
arantius added a commit to arantius/greasemonkey that referenced this issue Sep 13, 2017
@arantius
Copy link
Collaborator Author

https://addons.mozilla.org/firefox/downloads/file/722216/greasemonkey-3.12beta1-fx.xpi?src=devhub

I've added support for pushing data into the (embedded) webextension in 3.12. This is impossible to test without building yourself a webext version of Greasemonkey, but testing that 3.12 continues to work without new bugs would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants