Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trigger install while globally disabled #2643

Closed
arantius opened this issue Nov 3, 2017 · 0 comments
Closed

Don't trigger install while globally disabled #2643

arantius opened this issue Nov 3, 2017 · 0 comments
Milestone
4.3

Comments

@arantius
Copy link
Collaborator

arantius commented Nov 3, 2017

In legacy Greasemonkey: while globally disabled we would ignore navigation to scripts and not pop the install dialog.

In 4.0, navigation to an appropriate URL always pops the dialog. We should restore the old behavior.
@arantius arantius added this to the 4.1 milestone Nov 3, 2017
@arantius arantius modified the milestones: 4.1, 4.2 Nov 23, 2017
@arantius arantius modified the milestones: 4.2, 4.3 Jan 5, 2018
@arantius arantius modified the milestones: 4.3, 4.4 Jan 19, 2018
@Sxderp Sxderp mentioned this issue Jan 19, 2018
Merged
Sxderp added a commit to Sxderp/greasemonkey that referenced this issue Jan 20, 2018
@Sxderp
Dont open install dialog if GM is disabled
d5beb92 
 greasemonkey#2643
Sxderp added a commit to Sxderp/greasemonkey that referenced this issue Jan 22, 2018
@Sxderp
Dont open install dialog if GM is disabled
8143de5 
 greasemonkey#2643
Sxderp added a commit to Sxderp/greasemonkey that referenced this issue Jan 22, 2018
@Sxderp
Dont open install dialog if GM is disabled
7790d90 
 greasemonkey#2643
@arantius arantius modified the milestones: 4.4, 4.3 Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
1 participant
@arantius