New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to vector icon #2739
Comments
The first half has nothing to do with us. The second: We've got the assets we've got, I can't do much about that. |
Is contribution welcome? I can try to make a bigger one for you. |
We're open source, so the simple answer is yes. I've grown pretty attached to this particular imagery over the years we've had it though so, how closely can you match the style? |
Nice. Vectors hopefully? |
Yes, in svg format. We can also get a flatter one by removing the gradient effect. |
Just to sanity check, what I see now. Both with
Differences remain, but they're tiny, and the SVG form looks good at all sizes. Let's move forward! |
Is there anything else, or is it just this issue needs to be closed and #2749 merged? |
There's just some delay between when I make comments (real time) and when I build/test/merge/push/etc. -- the latter often bundles a few things. |
I'll keep polishing it in my spare time. :D The svg icon is undoubtedly flat because it is hard to have fine-grain control of the gradience effect without utilizing embedded rasterized image. |
Tested on Firefox 57, 58
The biggest icon provided by GM is not big enough. It should be at least 96x96 (192x192 or larger for high dpi displays).
Firefox can auto-sacle a big image (like 400x400) for GM, so a bigger icon always helps.
UPDATE: opened an issue for Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1422026
The text was updated successfully, but these errors were encountered: