Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a SAVE Button to the Editor #2785

Closed
erosman opened this issue Dec 30, 2017 · 3 comments
Closed

Add a SAVE Button to the Editor #2785

erosman opened this issue Dec 30, 2017 · 3 comments
Milestone
4.2

Comments

@erosman
Copy link

erosman commented Dec 30, 2017

Adding a save button (well, tab like button next to the name tab in editor) would make it more user-friendly for the average user and it should be easy to implement.
@ghost ghost mentioned this issue Jan 5, 2018
Merged
@arantius
Copy link
Collaborator

arantius commented Jan 5, 2018

The above fix has been packaged in a new beta version:
https://addons.mozilla.org/firefox/downloads/file/830369/greasemonkey-4.2beta1-an+fx.xpi?src=devhub

Testing and confirmation would be appreciated!

@arantius arantius added this to the 4.2 milestone Jan 5, 2018
@erosman
Copy link
Author

erosman commented Jan 5, 2018 •
edited

Testing and confirmation would be appreciated!

I am going to try 4.2b and let you know.
@arantius Save button works fine.
#2693 doesnt work. How come it was removed?

@Eselce
Copy link
Contributor

Eselce commented Jan 5, 2018

#2693 doesnt work. How come it was removed?

It just doesn't work as expected, see the pull request thread...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
3 participants
@arantius @erosman @Eselce