Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native-like Monkey Menu needs fixes or roll-back #2816

Closed
arantius opened this issue Jan 26, 2018 · 7 comments
Closed

Native-like Monkey Menu needs fixes or roll-back #2816

arantius opened this issue Jan 26, 2018 · 7 comments
Milestone

Comments

@arantius
Copy link
Collaborator

The monkey menu after #2805 looks a lot better. Except the little "next page" arrows look awkward when there are enough install scripts to trigger a scroll bar:

screenshot from 2018-01-26 10 12 07b

It seems like the scroll bar layers on top of, rather than beside, the content.

@arantius arantius added this to the 4.3 milestone Jan 26, 2018
@Sxderp
Copy link
Contributor

Sxderp commented Jan 26, 2018

RIP, I remember testing this and not having any problems. Must be platform / X environment dependent. Of course, aesthetic compatibility is ideal.

@arantius arantius changed the title Native-like Monkey Menu doesn't handle scroll bar well Native-like Monkey Menu needs fixes or roll-back Jan 27, 2018
@arantius
Copy link
Collaborator Author

This change needs either fixes or to be backed out.

See above problem, and issues mentioned in #2650, and I also get visual glitches on Windows. On Windows every line seems much taller than on Linux, and if I scroll down I get:

mm

A bunch of non-erased garbage behind the real elements at the bottom. If I scroll slowly, I can see each item, as it should disappear of the top instead pop in at the bottom, then disappear after a few further pixels of scrolling.

If I click into one script, the scroll bar keeps the height of the main view, giving me lots of nothing to scroll into. If I do and scroll back up, I get black flashes. If I do so slowly, they don't flash, I can get:

mezer_01-27_16-04-28

Quite a lot of visual corruption.

@Eselce
Copy link
Contributor

Eselce commented Jan 27, 2018

Can confirm the scrollbar and the "garbage". Happened to me as well (win system)...

@Sxderp
Copy link
Contributor

Sxderp commented Jan 27, 2018

The visual glitches aren't strictly caused by the changes.

There's some Bugzilla posts about these issues. Of course, rolling back until Mozilla gets their shit together is always possible.

@arantius
Copy link
Collaborator Author

Maybe I haven't looked closely before (testing profiles usually don't have enough scripts installed to scroll...) but even if the cause is a buggy platform, I can't recall seeing things like this before.

@Sxderp
Copy link
Contributor

Sxderp commented Jan 27, 2018

but even if the cause is a buggy platform, I can't recall seeing things like this before.

It's probably that the old styles didn't cause the issue to be prominent. I have a css fix that'll deal with the scrollbar, and somewhat resolve the graphical glitches, and inadvertently fix #2694 (lol).

I'll post shortly.

@arantius
Copy link
Collaborator Author

arantius commented Feb 2, 2018

Fixed by #2818 .

@arantius arantius closed this as completed Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants