GM.xmlHttpRequest not reaching readyState==4 #2980

pjb1008 · 2018-07-02T14:32:46Z

Hi,

I am using GM.xmlHttpRequest to send and receive XML documents. (They're actually just strings as far as GM is concerned - I serialise and parse them myself.)

This worked in GM 4.4, but with GM 4.5 the onload function is never called so my program stops at that point. onreadystatechange is called with readyState 3, but the readyState never gets to 4.

I can't see anything in the changelog that looks like a relevant change. Any help would be appreciated.

Peter

arantius · 2018-07-02T15:15:01Z

https://wiki.greasespot.net/Greasemonkey_Manual:Getting_Help#What_to_Say

Exact version of everything involved? Exact script that produces this?

arantius · 2018-07-02T15:22:46Z

https://github.com/greasemonkey/greasemonkey/blob/master/test/scripts/api-xhr.user.js

We didn't have one (!) so I just added a test script, which for me logs:

gm_xhr onprogress lengthComputable:  true GM.xmlhttpRequest() test.:507:5
gm_xhr onprogress loaded:  1081 GM.xmlhttpRequest() test.:508:5
gm_xhr onprogress total:  1081 GM.xmlhttpRequest() test.:509:5
gm_xhr onprogress lengthComputable:  true GM.xmlhttpRequest() test.:507:5
gm_xhr onprogress loaded:  1081 GM.xmlhttpRequest() test.:508:5
gm_xhr onprogress total:  1081 GM.xmlhttpRequest() test.:509:5
GM_xmlhttpRequest works:  <!DOCTYPE HTML PUBLIC "-//W3C/ GM.xmlhttpRequest() test.:504:5

I.e. it works.

pjb1008 · 2018-07-02T15:27:20Z

On Mon, 2 Jul 2018, arantius wrote: gm_xhr onprogress total: 1081 GM.xmlhttpRequest() test.:509:5 GM_xmlhttpRequest works: <!DOCTYPE HTML PUBLIC "-//W3C/ GM.xmlhttpRequest() test.:504:5 I.e. it works.

Thank you. I'll dig a bit deeper to try an make a minimal test case for the problem. Peter

pjb1008 · 2018-07-02T16:11:50Z

On Mon, 2 Jul 2018, arantius wrote: https://github.com/greasemonkey/greasemonkey/blob/master/test/scripts/api-xhr.user.js We didn't have one (!) so I just added a test script, which for me logs:

Hi, I've done a few quick tests, and have got the test case down to: / ==UserScript== // @name testpjb // @Version 1 // @grant GM.xmlHttpRequest // @include http://(my-desktop).eng.cam.ac.uk/~pjb1008/ // ==/UserScript== var xmlstring = '<requests><request reqtype="lookup_po" po_number="123456"/></requests>'; var server_url='https://(my-server).eng.cam.ac.uk/my-cgi-script'; GM.xmlHttpRequest({ method: 'POST', url: server_url, headers: {'Content-Type': 'text/xml', "Accept": "text/xml" }, data: xmlstring, onload: function(response) { console.log('load', response) }, onreadystatechange: function(response) { console.log('statechange', response) }, }); I've obscured a few private details, but you get the idea. If I set server_url to something that returns an ordinary web page, it just works as expected. If I set server_url to something that returns an XML document, is stops in state 3 and never calls onload. This is the XML document that the server returned: Content-Type: text/xml; charset=utf8 <?xml version=\"1.0\"?> <requests> <request reqtype="lookup_po" po_number="123456" warn="Can't find PO"/> </requests> This was visible and complete in the responseText with readyState 3. If I change the server so that it claims Content-Type: text/plain instead of text/xml then it gets all the way through to state 4. Peter

makyen · 2018-07-03T22:47:40Z

@pjb1008 You have not provided the information mentioned in the What to Say link. Specifically, Operating System and Firefox version.

I mention this because I'm tracking down an issue in a script I support that is also related to GM.xmlHttpRequest(), but which I haven't been able to duplicate in all environments. Thus, to know if the problem is the same as this one, it would be helpful to have those details from you.

pjb1008 · 2018-07-03T23:48:39Z

On Tue, 3 Jul 2018, Makyen wrote: @pjb1008 You have not provided the information mentioned in the What to Say link. Specifically, Operating System and Firefox version. I mention this because I'm tracking down an issue in a script I support that is also related to GM.xmlHttpRequest(), but which I haven't been able to duplicate in all environments. Thus, to know if the problem is the same as this one, it would be helpful to have those details from you.

Hi, My issue was on Firefox 60 on SuSE Linux 13.1. The firefox is the version downloaded from mozilla.org, not one packaged by SuSE or its contributors. I have the following extensions: - FoxyProxy Standard - Disable JavaScript - Stylish - GreaseMonkey (obviously) The problem was reported to me by a Windows user - I shall check the version they were using tomorrow. Peter

pjb1008 · 2018-07-04T11:17:07Z

On Wed, 4 Jul 2018, P. Benie wrote: The problem was reported to me by a Windows user - I shall check the version they were using tomorrow.

The Windows machine exhibiting the same problem was FF60 on Windows 10 version 1803. Peter

Cerberus-tm · 2018-07-04T18:05:34Z

@pjb1008 Hmm if you could add in a real url, then people could test it more easily. Would it be possible to replace the censored url with some other, real url that testers can access?

arantius · 2018-07-04T19:56:22Z

This script directly reproduces the failure; onprogress fires but onload does not, when response is XML.

arantius · 2018-07-09T14:23:32Z

Finally found a traceback of the error:

 DataCloneError: The object could not be cloned. on-user-script-xhr.js:80
_sendMessage     resource://gre/modules/ExtensionChild.jsm:279:18
postMessage     resource://gre/modules/ExtensionChild.jsm:223:5
postMessage     resource://gre/modules/ExtensionChild.jsm:179:9
xhrEventHandler     moz-extension://.../src/bg/on-user-script-xhr.js:80:5
xhrEventHandler self-hosted:1031:17

The true failure seems to be in passing the message. I "fixed" a bug that copied the responseXML to nowhere in an unrelated clean up CL. Now it's being passed, to a place that it can't be handled. The XML object is not message-passing-cloneable. And we're doing the XHR in the background process, so we have to message pass the results to the content process where the user script is running.

arantius · 2018-07-09T15:38:45Z

This should be fixed in the latest nightly build ( https://arantius.com/misc/gm-nightly/greasemonkey-2018.07.09.nightly.33eca3f6.xpi ). Confirmation would be great!

Cerberus-tm · 2018-07-09T18:26:00Z

That seems to work for me, thanks for the fix!:

[Virtual Machine, Windows 7, Firefox 61.0.1 (32 bits), the GM nightly from the previous message.]

The only thing that doesn't seem to work is getting an html file and having it parsed like a DOM, which did work in GM 3. The following code (except for GM.xmlHttpRequest, of course) worked in GM 3, but not in GM 4:

// ==UserScript==
// @name        GM.xmlhttpRequest() test w/ XML.
// @description Exercise the XHR API, downloading an XML file.
// @version     1
// @grant       GM.xmlHttpRequest
// ==/UserScript==

GM.xmlHttpRequest({
  method: 'GET',
  //url: 'http://google.com/sitemap.xml',
  url: 'http://google.com/',  //This has been added.
  responseType: "document",  //This has been added.
  onload: function(response) {
    //console.log('GM_xmlhttpRequest works: ', response.responseText.substring(0, 30));
    console.log( response.responseXML);  //This has been added.
  },
  onprogress: function(e) {
    console.log('gm_xhr onprogress lengthComputable: ', e.lengthComputable);
    console.log('gm_xhr onprogress loaded: ', e.loaded);
    console.log('gm_xhr onprogress total: ', e.total);
  }
});

It gives the following error in the browser console (though nothing in the web console):

 DataCloneError: The object could not be cloned. on-user-script-xhr.js:81
_sendMessage
resource://gre/modules/ExtensionChild.jsm:279:18
postMessage
resource://gre/modules/ExtensionChild.jsm:223:5
postMessage
resource://gre/modules/ExtensionChild.jsm:179:9
xhrEventHandler
moz-extension://579a1921-87ee-4388-8d08-55e0837f90e1/src/bg/on-user-script-xhr.js:81:5
xhrEventHandler self-hosted:1027:17

Screenshot:

Or is that entirely unrelated? Should I file it as a separate issue?

arantius added this to the 4.6 milestone Jul 2, 2018

makyen mentioned this issue Jul 3, 2018

"Failed sending chat request message. You must login to post" when attempting to send a CV request SO-Close-Vote-Reviewers/UserScripts#136

Closed

arantius added the confirmed label Jul 4, 2018

arantius closed this as completed in 80b179b Jul 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GM.xmlHttpRequest not reaching readyState==4 #2980

GM.xmlHttpRequest not reaching readyState==4 #2980

pjb1008 commented Jul 2, 2018

arantius commented Jul 2, 2018

arantius commented Jul 2, 2018

pjb1008 commented Jul 2, 2018 via email

pjb1008 commented Jul 2, 2018 via email

makyen commented Jul 3, 2018

pjb1008 commented Jul 3, 2018 via email

pjb1008 commented Jul 4, 2018 via email

Cerberus-tm commented Jul 4, 2018

arantius commented Jul 4, 2018

arantius commented Jul 9, 2018

arantius commented Jul 9, 2018

Cerberus-tm commented Jul 9, 2018 •

edited

GM.xmlHttpRequest not reaching readyState==4 #2980

GM.xmlHttpRequest not reaching readyState==4 #2980

Comments

pjb1008 commented Jul 2, 2018

arantius commented Jul 2, 2018

arantius commented Jul 2, 2018

pjb1008 commented Jul 2, 2018 via email

pjb1008 commented Jul 2, 2018 via email

makyen commented Jul 3, 2018

pjb1008 commented Jul 3, 2018 via email

pjb1008 commented Jul 4, 2018 via email

Cerberus-tm commented Jul 4, 2018

arantius commented Jul 4, 2018

arantius commented Jul 9, 2018

arantius commented Jul 9, 2018

Cerberus-tm commented Jul 9, 2018 • edited

Cerberus-tm commented Jul 9, 2018 •

edited