New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping a .user.js onto the new script manager fails to trigger installation #1142
Comments
I've taken that and added a bit to make it functional. Based on the way ScriptDownloader works, the install dialog is attached to the browser window, not the addons window. But that's probably good enough for now. http://github.com/arantius/greasemonkey/compare/master...issue_1142 |
Basic support for drag/drop user scripts on the addons window to install. Closed by dd22c58 |
I'm not sure we can close this since it's not getting past the first line of GM_installUri. |
Indeed.
Whoops! |
Well, correcting the But now, I'm seeing tons of crazy bugs. Perhaps a Linux thing, I didn't first develop this on Linux, but that's where I am now. I've pushed the easy fix, so it should show up in the next nightly. Then I'll have to dig into these bugs. |
I can confirm the weird behavior you noticed under Linux. The relevant part I changed in urlFromDragEvent:
|
Reimplement with nsDragAndDrop, which works cross platform. Closed by 98d0b3b |
Is it known that feature issue is no longer working in master (drop script from filesystem anywhere, ff3.6) Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: chrome://greasemonkey/content/scriptdownloader.js :: anonymous :: line 74" data: no] |
What is easily accessible now to test, Could you provide an exact user-agent string like this where you're seeing failure? |
|
K. This bug was the new manager, and in 0.9.0. For the old one: #1381 |
Dropping a script on the userscript tab of the addon manager of FF5 results in "this addon could not be installed because it appears to be corrupt" |
Same problem here. |
In examining the new userscript manager drag and drop features I realized it should probably behave as the extensions tab of the manager, where dropping an extension onto the list triggers install of that extension, ideally the same can be true for userscripts, and ideally the script installs and script execution order reflects the location that it was dropped onto the list.
I started work on this issue, validating file is user.js and getting the URL to file when one is dropped on the Userscript List in Addon Manager.
http://github.com/qufighter/greasemonkey/compare/master...issue_1142
The text was updated successfully, but these errors were encountered: