Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct scripts should have distinct file names #76

Closed
arantius opened this issue Apr 3, 2014 · 5 comments
Closed

Distinct scripts should have distinct file names #76

arantius opened this issue Apr 3, 2014 · 5 comments

Comments

@arantius
Copy link

arantius commented Apr 3, 2014

See greasemonkey/greasemonkey#1906 . We need to fix thatin Greasemonkey, but it is being triggered by the fact that all scripts hosted on greasyfork have the exact same file name (code.user.js). Having distinct file names would be nice.

This is probably a dupe of #75 which I can't reopen. I consider it a valid feature request, so I'll continue filing it.

@JasonBarnabe
Copy link
Collaborator

Other than avoiding that bug, I'm having a hard time thinking of ways having different end parts of the URL is "nice".

#73 would likely result in URLs like https://greasyfork.org/scripts/123-script-name/code.user.js which I'm going to guess is not enough to avoid the bug.

@arantius
Copy link
Author

arantius commented Apr 3, 2014

Other ways:

  • If I edit the installed script, I can see which is which in my editor's tabs.
  • If I archive the files, they can be saved in the same directory without manually renaming each one.

@JasonBarnabe
Copy link
Collaborator

It seems a bit odd to me that Greasemonkey uses the end part of the URL for anything. It does updates based on @name and @namespace, and @name is what's presented as the identifier to users. It definitely doesn't make much sense in my context where these aren't actually files in a directory...

On userstyles.org I do (name).user.js, where the name part actually doesn't matter to the server, so I can probably do similar here.

@arantius
Copy link
Author

arantius commented Apr 5, 2014

It seems a bit odd to me that Greasemonkey uses the end part of the URL for anything.

Greasemonkey has a URL and wants to save a file. URLs are traditionally organized like file paths, slash delimited, where the last part is the file name. So that's the file name that Greasemonkey uses to save the file. Seems perfectly logical to me.

Right click and pick save as, and you'll get the exact same behavior.

@JasonBarnabe
Copy link
Collaborator

The site will now offer URLs like https://greasyfork.org/scripts/358-video-wipe-ads/code/Video%20wipe%20ADs.user.js

The old format will continue to work but will not be linked to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants