How to make this work with `npm ci`?

[Stupidism]

I tried in travis and circleci:

install:
  - npm i -g npm@6
  - npm ci

# greenkeeper update npm lockfile
before_install:
  - npm install -g greenkeeper-lockfile@1
  - greenkeeper-lockfile-update
after_success:
  - greenkeeper-lockfile-upload
  - bash <(curl -s https://codecov.io/bash)

      - run:
          name: Install greenkeeper-lockfile
          command: npm i greenkeeper-lockfile@1
      - run:
          name: Update lock file
          command: ./node_modules/.bin/greenkeeper-lockfile-update
      - run:
          name: Install dependencies in ci mode
          command: npm ci
# Prevent to upload lockfile twice, because travis will upload, too.
#      - run:
#          name: Upload new lock file
#          command: ./node_modules/.bin/greenkeeper-lockfile-upload

But it always complains:

This build should not update the lockfile. It could be a PR, not a branch build.

ci scripts: travis
circleci

ci results: travis
circleci

[freaktechnik]

It seems travis now defaults to npm ci, which means this is much more often a problem.

Traivs CI run: https://travis-ci.org/freaktechnik/github-stub/builds/386634973
.travis.yml: https://github.com/freaktechnik/github-stub/blob/67273161087b04074aa829be1f134dd52088f2ee/.travis.yml

[daffl]

It looks like this will be happening now for all new Greenkeeper PRs with a breaking version change that run on the latest Node. It can be solved by reverting the default script in your .travis.yml to

install: npm install

I ended up getting the same error message as @Stupidism setting up greenkeeper-lockfile and digging into the code a little, I'm wondering if the travis.correctBuild flag at https://github.com/greenkeeperio/greenkeeper-lockfile/blob/master/ci-services/travis.js#L14 should really check if it is a Greenkeeper PR branch.

That's what seems to be happening for some other CI services already (e.g. for Codeship at https://github.com/greenkeeperio/greenkeeper-lockfile/blob/master/ci-services/codeship.js#L33).

[espy]

Hi @daffl , thanks for jumping in here, that is indeed the way to go for now 👍

We’ve got the problem on our list and will deal with it within the monorepo PR for gk-lockfile that we’re currently working on.

[BerkeleyTrue]

I've created a script that will conditionally use npm install/npm ci on travis ci depending on whether the branch is a greenkeeper branch.

A gist including travis config example. https://gist.github.com/BerkeleyTrue/ff98c0aa27c21e1616f6bf910f444aee