Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not upgrade from gulp 3 to gulp 4 #1042

Open
TwitchBronBron opened this issue Feb 8, 2019 · 2 comments
Open

Should not upgrade from gulp 3 to gulp 4 #1042

TwitchBronBron opened this issue Feb 8, 2019 · 2 comments

Comments

@TwitchBronBron
Copy link

Greenkeeper tried to upgrade gulp 3 to gulp 4 in one of my projects (https://github.com/TwitchBronBron/MessageManager/pull/1/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R21).

The problem is, gulp 4 has a few major breaking changes compared to gulp 3, so almost every v3 gulpfile needs to be rewritten to support the new gulp 4 syntax.

Is this something that greenkeeper should restrict (i.e. only ever upgrade gulp 3 to higher gulp 3 versions, same with gulp 4), or are greenkeeper users expected to fix all CI build failures before merging the greenkeeper pull requests?

@GregTheGreek
Copy link

@TwitchBronBron did you ever solve this?

@TwitchBronBron
Copy link
Author

TwitchBronBron commented Jun 28, 2019

@GregTheGreek, I haven't heard anything from the greenkeeper team, and I gave up using greenkeeper because I found it to be more effort than it was worth for me. So, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants