Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group peerDependencies into a single PR #1064

Open
honzajavorek opened this issue Mar 26, 2019 · 2 comments
Open

Group peerDependencies into a single PR #1064

honzajavorek opened this issue Mar 26, 2019 · 2 comments

Comments

@honzajavorek
Copy link

Example situation: apiaryio/dredd-transactions#259

The adapter packages have a peer dependency on the fury package. It's not wise to upgrade them one-by-one, they should get all upgraded together with the fury package. Every time fury and the adapters release a new version, I get four separate PRs. What I need is a single PR updating all of these, and testing their interplay. Every time we have to prepare the PR manually and to manually close the automated PRs.

@kylef
Copy link

kylef commented Mar 26, 2019

To add more context, in this particular case these libraries depend on an exact version of a peer dependency, and thus they must be updated together for compatibility. Here's an example dependency graph:

package - greenkeeper managed package
└── dependencies
    ├── fury-adapter-apib-parser
    │   └── peerDependencies
    │       └── fury@3.0.0-beta.10
    ├── fury-adapter-oas3-parser
    │   └── peerDependencies
    │       └── fury@3.0.0-beta.10
    └── fury@3.0.0-beta.10

@travi
Copy link

travi commented Mar 26, 2019

some grouping is supported through https://github.com/greenkeeperio/monorepo-definitions. would defining the project that you want grouped there help with your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants