Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultApplicationConfigurer dependency on MVC Group 'instantiation' lifecycle event #115

Open
shnplr opened this issue Oct 4, 2015 · 2 comments

Comments

@shnplr
Copy link

shnplr commented Oct 4, 2015

Controller actions do not get created when instantiation event is disabled.

    config {
        events {
            instantiation = false
        }
    }

DefaultApplicationConfigurer has at least 2 dependencies on this event.

Can the Griffon guide please be updated to indicate this, as well disabling events can break plugins - e.g. Preferences plugin is dependent on the event (refer AbstractPreferencesManager constuctor). Specific dependencies on application lifecycle events could be listed in plugin guides.

@aalmiray
Copy link
Member

aalmiray commented Oct 9, 2015

actually the Injector listens to NewInstance to invoke methods annotated with @PostConstruct. I'm thinking that adding the feature to skip instantiation and destruction events was not a good idea. Out of curiosity, why do you have to skip these events?

@shnplr
Copy link
Author

shnplr commented Oct 11, 2015

I was simply trying out the feature and ran into the issue - I was considering disabling events for some performance gain. I agree that disabling a feature which skips events required by the core framework makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants