Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bool instead of grn_bool #1638

Open
kou opened this issue Dec 8, 2023 · 3 comments
Open

Use bool instead of grn_bool #1638

kou opened this issue Dec 8, 2023 · 3 comments
Labels
Feature

Comments

@kou
Copy link
Member

kou commented Dec 8, 2023

What is your problem?

We introduced grn_bool for compatibility. But we can always use bool on all supported environments now.

We should do this step by step. We must not open one large PR that includes all changes. We can't review it.

How to reproduce it

No response
@kou kou added the Feature label Dec 8, 2023
@abetomo
Copy link
Contributor

abetomo commented Jan 11, 2024 •
edited

We will fix it with small changes such as file by file.

Target files.

grep -lr grn_bool *

  • benchmark/bench-query-optimizer.c
  • benchmark/bench-range-select.c
  • include/groonga/plugin.h
  • include/groonga/array.h
  • include/groonga/expr.h
  • include/groonga/time.h
  • include/groonga/config.h
  • include/groonga/tokenizer_query_deprecated.h
  • include/groonga/id.h
  • include/groonga/ii.h
  • include/groonga/operator.h
  • include/groonga/output.h
  • include/groonga/command.h
  • include/groonga/token.h
  • include/groonga/table.h
  • include/groonga/request_canceler.h
  • include/groonga/type.h
  • include/groonga/obj.h
  • include/groonga/tokenizer.h
  • include/groonga/cast.h
  • include/groonga/groonga.h
  • include/groonga/db.h
  • lib/pat.c
  • lib/sort.c
  • lib/group.c
  • lib/output.c
  • lib/grn_pat.h
  • lib/window_function.c
  • lib/io.c
  • lib/grn_ecmascript.lemon
  • lib/grn_scanner.h
  • lib/index_column.c
  • lib/grn_ecmascript.c
  • lib/expr_executor.cpp
  • lib/grn_ctx_impl.h
  • lib/logger.c
  • lib/options.c
  • lib/time.c
  • lib/expr.c
  • lib/grn_load.h
  • lib/mrb.c
  • lib/command.c
  • lib/grn_util.h
  • lib/grn_io.h
  • lib/grn_table.h
  • lib/plugin.c
  • lib/grn_onigmo.h
  • lib/type.c
  • lib/grn_alloc.h
  • lib/grn_expr.h
  • lib/alloc.c
  • lib/cache.c
  • lib/token.c
  • lib/request_canceler.c
  • lib/grn_tokenizer.h
  • lib/output_columns.c
  • lib/tokenizer.c
  • lib/ii.c
  • lib/grn_mrb.h
  • lib/grn_geo.h
  • lib/grn_options.h
  • lib/string.c
  • lib/grn_store.h
  • lib/grn_com.h
  • lib/grn_request_timer.h
  • lib/util.c
  • lib/grn_request_canceler.h
  • lib/geo.c
  • lib/grn_proc.h
  • lib/grn_dat.h
  • lib/dat.cpp
  • lib/request_timer.c
  • lib/str.c
  • lib/id.c
  • lib/vector.cpp
  • lib/onigmo.c
  • lib/file_lock.c
  • lib/highlighter.c
  • lib/operator.c
  • lib/tokenizers.c
  • lib/msgpack.c
  • lib/store.c
  • lib/grn_error.h
  • lib/ctx_impl_mrb.c
  • lib/scanner.c
  • lib/mrb/mrb_expr.h
  • lib/mrb/mrb_converter.c
  • lib/mrb/mrb_bulk.c
  • lib/mrb/mrb_object.c
  • lib/mrb/mrb_index_cursor.c
  • lib/mrb/mrb_expr.c
  • lib/mrb/mrb_database.c
  • lib/mrb/mrb_bulk.h
  • lib/arrow.cpp
  • lib/file_reader.c
  • lib/proc/proc_fuzzy_search.c
  • lib/proc/proc_object.c
  • lib/proc/proc_table.c
  • lib/proc/proc_select.cpp
  • lib/proc/proc_tokenize.c
  • lib/proc/proc_dump.c
  • lib/proc/proc_column.c
  • lib/proc/proc_schema.c
  • lib/proc/proc_object_list.c
  • lib/normalizer.c
  • lib/grn_str.h
  • lib/grn_token.h
  • lib/config.c
  • lib/grn_nfkc.h
  • lib/grn_file_lock.h
  • lib/accessor.c
  • lib/hash.c
  • lib/grn_table_selector.h
  • lib/romaji.c
  • lib/window_function_executor.cpp
  • lib/ctx.c
  • lib/grn_hash.h
  • lib/db.c
  • lib/proc.c
  • lib/obj.c
  • lib/grn_db.h
  • plugins/query_expanders/tsv.c
  • plugins/tokenizers/mecab.c
  • plugins/token_filters/stem.c
  • plugins/suggest/suggest.c
  • src/groonga.c
  • src/suggest/groonga_suggest_create_dataset.c
  • src/suggest/groonga_suggest_httpd.c
  • src/suggest/util.c
  • test/unit/core/test-table.c

Unnecessary files have already been removed from the list as noted in #1638 (comment).

@kou
Copy link
Member Author

kou commented Jan 11, 2024

We don't need to update the followings:

  • doc/: We should update the API reference based on code comment eventually. (We don't have a mechanism for it yet...)
  • test/mruby/rroonga/: It's an external repository: https://github.com/ranguba/rroonga

@abetomo abetomo mentioned this issue Jan 11, 2024
Merged
kou pushed a commit that referenced this issue Jan 11, 2024
@abetomo
Change grn_id_is_builtin to return bool instead of grn_bool (#1661)
4e69fef 
GH-1638

Related `grn_obj_is_builtin` was also changed to return bool.
This was referenced Jan 11, 2024
Merged
Merged
kou pushed a commit that referenced this issue Jan 11, 2024
@abetomo
Change grn_type_id_is_builtin to return bool instead of grn_bool (#…
3f2cb70 
…1662)

GitHub: GH-1638

Related changes to `grn_id_is_builtin_type`.
This was referenced Jan 11, 2024
Merged
Merged
@abetomo
Copy link
Contributor

abetomo commented Jan 11, 2024

GRN_TRUE and GRN_FALSE must also be replaced.

kou pushed a commit that referenced this issue Jan 11, 2024
@abetomo
Change grn_type_id_is_number_family to return bool instead of grn_b…
e1fac23 
…ool (#1663)

GitHub: GH-1638

Related changes to `grn_obj_is_number_family_bulk`.
kou pushed a commit that referenced this issue Jan 11, 2024
@abetomo
Change grn_type_id_is_text_family to return bool instead of grn_bool (
e8f9b7d 
#1664)

GitHub: GH-1638
kou pushed a commit that referenced this issue Jan 11, 2024
@abetomo
Use bool instead of grn_bool in plugin.{h,c} (#1665)
91f674c 
GitHub: GH-1638

The related codes were also changed.
This was referenced Jan 11, 2024
Merged
Merged
kou pushed a commit that referenced this issue Jan 12, 2024
@abetomo
Use bool instead of grn_bool in sort.c (#1666)
716206d 
GitHub: GH-1638

The related `grn_pat_is_key_encoded` was also changed to use bool.
kou pushed a commit that referenced this issue Jan 12, 2024
@abetomo
Use bool instead of grn_bool in str.c and string.c (#1667)
4e84c41 
GitHub: GH-1638
@abetomo abetomo mentioned this issue Jan 14, 2024
Merged
kou pushed a commit that referenced this issue Jan 14, 2024
@abetomo
Use bool instead of grn_bool in window_function.c (#1668)
7dbae07 
GitHub: GH-1638
@abetomo abetomo mentioned this issue Jan 14, 2024
Merged
kou pushed a commit that referenced this issue Jan 15, 2024
@abetomo
Change the return value of grn_log_level_parse from grn_bool to bool (#…
c87dc7e 
…1669)

GitHub: GH-1638

The related codes were also changed.
Removed unnecessary else and unnecessary assignments.
@abetomo abetomo mentioned this issue Jan 15, 2024
Merged
kou pushed a commit that referenced this issue Jan 15, 2024
@abetomo
Use bool instead of grn_bool in logger.c (#1670)
19e3ffe 
GitHub: GH-1638
This was referenced Jan 15, 2024
Merged
Merged
kou pushed a commit that referenced this issue Jan 15, 2024
@abetomo
Use bool instead of grn_bool in util.c (#1671)
335c813 
GitHub: GH-1638

I also changed the relevant code in io.c.
kou pushed a commit that referenced this issue Jan 16, 2024
@abetomo
Use bool instead of grn_bool in time.{c,h} (#1672)
e10cea1 
GitHub: GH-1638
@abetomo abetomo mentioned this issue Jan 16, 2024
Merged
kou pushed a commit that referenced this issue Jan 16, 2024
@abetomo
Use bool instead of grn_bool in onigmo.{c,h} (#1674)
b8e2771 
GitHub: GH-1638
abetomo added a commit that referenced this issue Mar 11, 2024
@abetomo
Use bool instead of grn_bool in proc_object_list.c
89b91a0 
GH-1638
abetomo added a commit that referenced this issue Mar 11, 2024
@abetomo
Use bool instead of grn_bool in grn_select_sort
6e029b4 
Removed unnecessary `else`.

GH-1638
abetomo added a commit that referenced this issue Mar 21, 2024
@abetomo
Use bool instead of grn_bool in config.{c,h}
0e1ea10 
GH-1638
abetomo added a commit that referenced this issue Mar 26, 2024
@abetomo
Use bool instead of grn_bool in window_function_executor.cpp
6289549 
GH-1638
abetomo added a commit that referenced this issue Mar 30, 2024
@abetomo
Change grn_obj_is_table to return bool instead of grn_bool
9488876 
GH-1638

`lexicon_domain_is_table` was changed to bool since the return value
of `grn_obj_is_table` is assigned.
abetomo added a commit that referenced this issue Apr 1, 2024
@abetomo
Use bool instead of grn_bool in obj.{c,h}
d4cf0bf 
Not all of obj.{c,h} has been replaced.
In this commit, only some of it was replaced.

GH-1638
abetomo added a commit that referenced this issue Apr 4, 2024
@abetomo
Use bool instead of grn_bool in obj.{c,h}
5fec838 
Not all of obj.{c,h} has been replaced.
In this commit, only some of it was replaced.

GH-1638
abetomo added a commit that referenced this issue Apr 7, 2024
@abetomo
Use bool instead of grn_bool in request_timer.{c,h}
d1631f6 
GH-1638
abetomo added a commit that referenced this issue Apr 7, 2024
@abetomo
Use bool instead of grn_bool in request_canceler.{c,h}
dd6f49c 
GH-1638
abetomo added a commit that referenced this issue Apr 7, 2024
@abetomo
Use bool instead of grn_bool in request_canceler.h
0782208 
* Change the header file to match the implementation
* `canceled` is assigned the return value of `grn_request_canceler_cancel`

GH-1638
abetomo added a commit that referenced this issue Apr 9, 2024
@abetomo
Use bool instead of grn_bool in plugins/token_filters/stem.c
09b3777 
GH-1638
abetomo added a commit that referenced this issue Apr 13, 2024
@abetomo
Use bool instead of grn_bool in plugins/tokenizers/mecab.c
ece8390 
Not all of plugins/tokenizers/mecab.c has been replaced.
In this commit, only some of it was replaced.

GH-1638
abetomo added a commit that referenced this issue Apr 14, 2024
@abetomo
Use bool instead of grn_bool in plugins/tokenizers/mecab.c
f2dd106 
GH-1638
abetomo added a commit that referenced this issue Apr 16, 2024
@abetomo
Use bool instead of grn_bool in output.c
a7a1c20 
GH-1638
abetomo added a commit that referenced this issue Apr 18, 2024
@abetomo
Use bool instead of grn_bool in output.h
c681642 
Implementation is already bool.

GH-1638
abetomo added a commit that referenced this issue Apr 21, 2024
@abetomo
Use bool instead of grn_bool in expr_executor.cpp
25f415c 
Not all of expr_executor.cpp has been replaced.
In this commit, only some of it was replaced.

GH-1638
abetomo added a commit that referenced this issue Apr 23, 2024
@abetomo
Use bool instead of grn_bool in db.c
aba7036 
Not all of db.c has been replaced.
In this commit, only some of it was replaced.

GH-1638
abetomo added a commit that referenced this issue Apr 30, 2024
@abetomo
Use bool instead of grn_bool in suggest.c
51b4012 
GH-1638
abetomo added a commit that referenced this issue May 4, 2024
@abetomo
Use bool instead of grn_bool in grn_scanner_open()
41f0c59 
GH-1638
abetomo added a commit that referenced this issue May 5, 2024
@abetomo
Use bool instead of grn_bool in mrb.c
1811c15 
GH-1638
abetomo added a commit that referenced this issue May 9, 2024
@abetomo
Use bool instead of grn_bool in plugins/query_expanders/tsv.c
705180c 
GH-1638
abetomo added a commit that referenced this issue May 11, 2024
@abetomo
Use bool instead of grn_bool in grn_ctx_impl_should_log()
4df381d 
GH-1638
abetomo added a commit that referenced this issue May 11, 2024
@abetomo
Use bool instead of grn_bool in grn_error.h
c729984 
GH-1638
abetomo added a commit that referenced this issue May 12, 2024
@abetomo
Use bool instead of grn_bool in highlighter.c
d2119cc 
GH-1638
abetomo added a commit that referenced this issue May 16, 2024
@abetomo
Use bool instead of grn_bool in com.{c,h}
75ccbc5 
GH-1638
abetomo added a commit that referenced this issue May 27, 2024
@abetomo
Use bool instead of grn_bool in mrb_bulk.{c,h}
a01b1a2 
GH-1638
abetomo added a commit that referenced this issue Jun 1, 2024
@abetomo
Use bool instead of grn_bool in geo.c
080ce82 
Not all of geo.c has been replaced.
In this commit, only some of it was replaced.

GH-1638
abetomo added a commit that referenced this issue Jun 2, 2024
@abetomo
Use bool instead of grn_bool in ctx_impl_mrb.c
7699c85 
GH-1638
abetomo added a commit that referenced this issue Jun 9, 2024
@abetomo
Use bool instead of grn_bool in grn_lua_data
f72ee78 
GH-1638
abetomo added a commit that referenced this issue Jun 15, 2024
@abetomo
Use bool instead of grn_bool in mrb_converter.c
9aae765 
GH-1638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kou @abetomo